Opened 10 days ago

Closed 9 days ago

Last modified 6 days ago

#11246 closed defect (wontfix)

Don't include build date in program

Reported by: ryandesign Owned by: sev-
Priority: normal Component: --Unset--
Keywords: Cc:
Game:

Description

When I build scummvm and launch it, the window shows the date/time it was built. For the sake of reproducible builds, it shouldn't do that.

Change History (10)

comment:1 by dreammaster, 10 days ago

If you don't want it to include the date and time, build ScummVM in Release mode rather than Debug mode. As far as I'm aware, in release mode the results are reproducible.

comment:2 by ryandesign, 10 days ago

Hmm, I am configuring with --enable-release.

comment:3 by ryandesign, 10 days ago

I think the code that's adding this is in version.cpp.

comment:5 by dreammaster, 9 days ago

Owner: set to dreammaster
Resolution: outdated
Status: newclosed

This probably isn't a suitable place for discussing this any further, now that you've got specific code changes. What I'd request is that you do the standard procedure of forking ScummVM (if you haven't already), do the change in a branch, and create a pull request with those changes. It'll make it easier to discuss the change, and give you credit for them if your commit is accepted.

comment:6 by sev-, 8 days ago

This is done on purpose. The reliable way to refer to a build is to use the commit hash. The date is a human-readable version of that, and it is done on purpose.

comment:7 by sev-, 8 days ago

Owner: changed from dreammaster to sev-
Resolution: outdatedwontfix

comment:8 by ryandesign, 6 days ago

I agree that having the commit date shown in the program could be useful to some, but the build date has no relationship with the commit date and does not belong in the program.

You should reopen this ticket until you resolve the problem by no longer showing the build date in the program.

comment:9 by sev-, 6 days ago

Ryan, it is not quite clear what exactly is your problem, which apparently even urges you to give us the orders to do something. The patch you provided which "works for you" is simply removing the established and useful functionality without even second thought about an alternative.

The website you refer to is talking about the benefits for the privacy and security-related software. ScummVM is none of those.

comment:10 by ryandesign, 6 days ago

Sorry, I don't have time to help you further. I've reported the problem, the reasons, and the fix. What you do with it now is up to you.

Note: See TracTickets for help on using tickets.