Opened 15 months ago

Closed 5 months ago

Last modified 5 months ago

#11217 closed defect (fixed)

BUILD: --enable-release enables updates even on unsupported systems

Reported by: lotharsm Owned by: sev-
Priority: blocker Component: Common
Version: Keywords: updates, sparkle, linux
Cc: Game:

Description

Most likely due to a failing/missing check in the configure script, passing
--enable-release automatically enables the updates via (Win)Sparkle, even though the target platform might not even support this.

This leads to the update options being visible in the Misc tab of the GUI even though they're not functional as the systems don't support the update mechanism.

I'm setting this bug to HIGH as e.g. the packages distributed in Debian sid and Arch Linux are affected since they are built with --enable-release.

Change History (4)

comment:1 by sev-, 5 months ago

Priority: highnormal

comment:2 by sev-, 5 months ago

Priority: normalblocker

comment:3 by sev-, 5 months ago

Owner: set to sev-
Resolution: fixed
Status: newclosed

comment:4 by criezy, 5 months ago

I have reverted 581b4ca as this as the effect of disabling sparkle even if it is available.

Also the bug had already been fixed by rootfather in f204867 and 2615c68 (he even mentions in the commit message that this fixes this bug, but unfortunately it looks like he forgot to close this ticket).

Note: See TracTickets for help on using tickets.