Opened 13 months ago

Closed 13 months ago

Last modified 13 months ago

#11213 closed defect (duplicate)

QFG3 saving crash - Assertion `isValidRect()' failed.

Reported by: tomasz89 Owned by: sluicebox
Priority: blocker Component: Engine: SCI
Keywords: Cc:
Game: Quest for Glory 3

Description (last modified by tomasz89)

I'm in the Tarna inn, in the room doing some practice. Whenever I save, I get an assertion failure and ScummVM aborts.

This is a recent regression (within the past 5 days or so). Even a fresh new game will cause this whenever you try to save.

I am Linux, Ubuntu 19.04, on 3d83d144a361aee1bbaff00850f2efcd21683954.

Change History (6)

comment:1 by tomasz89, 13 months ago

Description: modified (diff)

comment:2 by sluicebox, 13 months ago

I'm available to look at this but QFG3 is one of the ones I don't know anything about, so please tailor your explanations accordingly =)

I tried saving in a few rooms with the latest code on Windows but couldn't reproduce, so I will pummel you with questions.

What room number(s) are you in? CTRL+D brings up the ScummVM debugger and typing "room" and hitting Enter will answer that. ("exit" or Esc to close the debugger.) A screenshot could help too. Are you still using the GOG version?

Did you enable the original Save/Restore screens in the Edit Game options, or are you using ScummVM's?

Are you building from source, and if so are you running configure with any parameters?

If you're building from source and can checkout earlier git commits and test those, you would be a huge help in determining where the regression occurred. Compiling will go a lot faster if you only include SCI with "./configure --disable-all-engines --enable-engine=sci --enable-engine=sci32". If you want to bisect this but made good life choices and don't know how, then this is is a good start: https://stackoverflow.com/a/4714297 (If you don't want to do this at all then count that as another good life choice)

I was about to say "can you attach a save?" but oh... right. If you have an existing save that loads and then crashes on save, that plus exact instructions to reproduce would be a big help. Or, exact instructions of what to do upon starting the game (What character type, how to get to which room...)

comment:3 by sluicebox, 13 months ago

Nevermind! I can reproduce this in ubuntu 19

comment:4 by tomasz89, 13 months ago

OK I assume then no further action on me for now - I just found a moment to dig around and look at the code etc but sounds like you're on it.

comment:5 by sluicebox, 13 months ago

Owner: set to sluicebox
Resolution: duplicate
Status: newclosed

Thanks for catching this, this is a bug that crashes the ScummVM save dialog and it affects every game/engine where it appears. It was introduced 10 days ago in 1dce33dd9f909b09a73902b3939b61a81a149b7a.

Now that we know it's a GUI bug I'm going to make a new issue with steps to reproduce so that it's easier for the commit author to follow without the Sierra stuff.

comment:6 by sluicebox, 13 months ago

Ticket #11214

Note: See TracTickets for help on using tickets.