Opened 5 years ago

Closed 5 years ago

#11029 closed defect (fixed)

QFG4: Restoring Autosave (aka save #0) restores save #1 instead

Reported by: lwcorp Owned by: sluicebox
Priority: normal Component: Engine: SCI
Version: Keywords:
Cc: Game: Quest for Glory 4

Description

Autosave, aka save number 0, saves all the times. The preview on it looks fine. But when trying to actually restore it then it restores save number 1 (specifically 1) instead.

Attachments (1)

version.png (1.7 KB ) - added by lwcorp 5 years ago.

Download all attachments as: .zip

Change History (6)

by lwcorp, 5 years ago

Attachment: version.png added

comment:1 by digitall, 5 years ago

Component: Port: Win64Engine: SCI

comment:2 by sluicebox, 5 years ago

Thank you for reporting this. You're right, loading the QFG4 autosave slot doesn't work any circumstance, and as far as I can tell it never did.

I tested the commit that added QFG4 autosave support and the behavior is the same: 2ccef4a4768c7f7574a7be0637e3791dc0e9d6ff

We have game-specific workaround code to make auto saving to slot 0 work, which for other games requires changes in two places, but QFG4 code was only added to one of them. This could take some work, those other workarounds rely on attributes that this game doesn't have.

comment:3 by sluicebox, 5 years ago

Other problems:

  • Loading slot 0 from command line loads slot 1
  • The automatic save game doesn't appear at all when using the game's original Restore dialog

I've got a fix for all of this that looks good so far, but I need to do more testing.

comment:4 by sluicebox <22204938+sluicebox@…>, 5 years ago

In 698ca46:

SCI32: Fix loading autosaves (slot 0)

Fixes bugs in trac #11029:

  • Slot 1 loading when user selects slot 0 in ScummVM UI
  • Slot 1 loading when slot 0 specified on command line
  • QFG4 slot 0 not appearing in game's original Restore UI

comment:5 by sluicebox, 5 years ago

Owner: set to sluicebox
Resolution: fixed
Status: newclosed

This affected every SCI32 game with autosave

Note: See TracTickets for help on using tickets.