Opened 2 weeks ago

Closed 2 weeks ago

#11010 closed patch (worksforme)

md5sum missing for Blade Runner - Italian version.

Reported by: eperulli Owned by: peterkohaut
Priority: normal Component: Engine: Bladerunner
Keywords: Blade Runner, md5sum Cc:
Game: Blade Runner

Description

I have a 4 CDs version of Blade Runner (Italian) which is not recognized by ScummVM.
So, I downloaded the source via git and added the new md5sum in engines/bladerunner/detection_tables.h:
a6264510ac22ba85f4c9dd7094464384
I modified the source as follows: (tested after compiling, the game runs)

// BladeRunner (Italian)
	{
		"bladerunner",
		0,
		AD_ENTRY1s("STARTUP.MIX", "a6264510ac22ba85f4c9dd7094464384", 2314461),
		Common::IT_ITA,
		Common::kPlatformWindows,
		ADGF_TESTING,
		GUIO2(GAMEOPTION_SITCOM, GAMEOPTION_SHORTY)
	},

And, for the restored content version:

 // BladeRunner (Italian)
	{
		"bladerunner-final",
		0,
		AD_ENTRY1s("STARTUP.MIX", "a6264510ac22ba85f4c9dd7094464384", 2314461),
		Common::IT_ITA,
		Common::kPlatformWindows,
		ADGF_TESTING,
		GUIO2(GAMEOPTION_SITCOM, GAMEOPTION_SHORTY)
	},

Change History (4)

comment:1 Changed 2 weeks ago by peterkohaut

That hash is already supported, but it is a hash for whole file. Notice that your hash is the same as the one on https://wiki.scummvm.org/index.php?title=Blade_Runner#Italian_CD_release

Detection table needs hash from first 5000 character only https://wiki.scummvm.org/index.php/Reporting_unknown_MD5_checksums

Last edited 2 weeks ago by peterkohaut (previous) (diff)

comment:2 Changed 2 weeks ago by peterkohaut

Also I have just tried to run latest development version from our website and Italian release of the game is detected successfully.
Please, can you specify what version are you using? Ideally commitid + platform as you are compiling it by yourself.

Last edited 2 weeks ago by peterkohaut (previous) (diff)

comment:3 in reply to:  2 Changed 2 weeks ago by eperulli

Replying to peterkohaut:

Also I have just tried to run latest development version from our website and Italian release of the game is detected successfully.
Please, can you specify what version are you using? Ideally commitid + platform as you are compiling it by yourself.

Just retested with the latest update from git,recompiled from scratch.
It seems to work now.
Until a few days ago, it didn't work without those code lines.

comment:4 Changed 2 weeks ago by peterkohaut

Owner: set to peterkohaut
Resolution: worksforme
Status: newclosed

Oh ... weird, because I didn't touch the routine for md5 calculation and how many characters it will use. I'm glad the original code is now working for you, closing the ticket.

Note: See TracTickets for help on using tickets.