Opened 5 months ago

Closed 5 months ago

Last modified 5 months ago

#10983 closed defect (fixed)

BLADERUNNER: GMM saved thumbnail is off

Reported by: dafioram Owned by: peterkohaut
Priority: low Component: Engine: Bladerunner
Keywords: Cc:
Game: Blade Runner

Description

2.1.0git5796-gbbed50ff27
bladerunner english

When looking at a save in the GMM the thumbnail coloring doesn't look right. When its viewed in the kia load it looks fine.

Attachments (1)

scummvm.png (153.0 KB ) - added by dafioram 5 months ago.

Download all attachments as: .zip

Change History (16)

comment:1 by antoniou79, 5 months ago

Can you provide an example with screenshots, please? Also is this on Windows or another platform?

comment:2 by peterkohaut, 5 months ago

i think i broke it when i switching rendering color format from hardcoded rgb555 to more universal one

by dafioram, 5 months ago

Attachment: scummvm.png added

comment:3 by dafioram, 5 months ago

Attached picture shows gmm picture and screenshot taken using alt+s.

comment:4 by peterkohaut, 5 months ago

i'm unable to replicate this issue, how did you created the save game? via gmm or via in game menu? perhaps can you share the save game?

from what i can see, it looks like that the background video didn't got into the thumbnail

comment:5 by dafioram, 5 months ago

I can have it happen by creating the save via kia or gmm. Have you tried with the win32 from the scummvm download site?

It shows in both linux and windows for me. Interestingly, If I resize the screen the thumbnail being shown will move to show different parts of the saved thumbnail.

comment:6 by peterkohaut, 5 months ago

hmm, i tried saving via kia and gmm with my builds (win 64, win 32, linux 64, linux 32) and with mingw-w32-master-2287a4f6 from dev builds, but seems its working for me, ill try on different machines as well.

I don't understand what is happening to you when you resize the window, I tried it and thumbnail is not changing - it is a bit smaller than the thumbnail area (that is expected, to keep compatibility of saves with original game) but otherwise no strange behavior.

comment:7 by dafioram, 5 months ago

If I look at the saved game thumbnails in the GMM before loading the engine then it has a black background and shows the actors.

If I start the engine then all the saves show the background of the room I am in, but the actors it shows are those that are for that particular saved game.

comment:8 by antoniou79, 5 months ago

It sort of sounds like it's treating the background in the thumbnails as transparent, but that is weird -- neither I am able to reproduce this on my system (win 64, linux 64) as of yet.

comment:9 by dafioram, 5 months ago

I found the difference, switch to openGL graphics mode.

comment:10 by lotharsm, 5 months ago

If I look at the saved game thumbnails in the GMM before loading the engine then it has a black background and shows the actors.

If I start the engine then all the saves show the background of the room I am in, but the actors it shows are those that are for that particular saved game.

I can confirm this, the thumbnails when loading via the GMM look somewhat off and improperly sized. Have yet to try if I can replicate the openGL behavior too.

comment:11 by peterkohaut, 5 months ago

I was able to reproduce this issue with opengl rendering, seems like background image is stored with transparent color and that area is transparent in GMM and also some previous stuff is rendered in there.

comment:12 by peterkohaut, 5 months ago

Owner: set to peterkohaut

comment:13 by Peter Kohaut <peter.kohaut@…>, 5 months ago

Resolution: fixed
Status: newclosed

In dd0c0302:

BLADERUNNER: Fixed alpha channel issues

Alpha channel is inverted in the game assets and that lead to issues in
OpenGL renderer. E.g. screenshot of savegames were partly black or
showing artifacts

closes #10983

comment:14 by peterkohaut, 5 months ago

So this issue helped me find bigger issue as we were not processing alpha channel correctly in few cases.
It's fixed now, but it is only fixing future thumbnails, the existing ones will still show this odd behavior. After a re-save they should be fine.

comment:15 by dafioram, 5 months ago

Nice work.

Note: See TracTickets for help on using tickets.