Opened 5 months ago

Last modified 5 weeks ago

#10981 new enhancement

Unknown game variant for The Journeyman Project: Pegasus Prime

Reported by: Duffadash Owned by: lotharsm
Priority: normal Component: Engine: Pegasus
Keywords: unknown-game Cc:
Game: Journeyman Project Pegasus Prime

Description

The game in 'PP Data' seems to be an unknown game variant.

Please report the following data to the ScummVM team at https://bugs.scummvm.org/ along with the name of the game you tried to add and its version, language, etc.:

Matched game IDs for the The Journeyman Project: Pegasus Prime engine: pegasus-mac

{"JMP PP Resources", 0, "d13a602d2498010d720a6534f097f88b", 2075337},

This is from a GOG installer

Attachments (1)

full_patch.diff (529.4 KB ) - added by Duffadash 5 months ago.

Download all attachments as: .zip

Change History (13)

comment:1 by lotharsm, 5 months ago

Owner: set to lotharsm

comment:2 by lotharsm, 5 months ago

Can you confirm the integrity of the data/files contained in the GoG installer? I wonder why the game is not detected since according to https://www.gog.com/game/journeyman_project_1_pegasus_prime_the the GoG release is already powered by ScummVM.

by Duffadash, 5 months ago

Attachment: full_patch.diff added

in reply to:  2 comment:3 by Duffadash, 5 months ago

Replying to lotharsm:

Can you confirm the integrity of the data/files contained in the GoG installer? I wonder why the game is not detected since according to https://www.gog.com/game/journeyman_project_1_pegasus_prime_the the GoG release is already powered by ScummVM.

The game launches and plays fine when using the executable. It is indeed using ScummVM, but a modified copy. Do note that this copy of Pegasus Prime is from an old (2014/2015'ish) installer that I no longer have lying around.

Here's the info from the provided "./docs/ScummVM Documentation/Windows/Special Build Info.txt" file:

This project uses a custom build of ScummVM licensed under GNU GPLv2 using revision d04667e58a889e4744f36fb5797a69fa437a1abf. You may obtain the sources from GitHub: https://github.com/scummvm/scummvm (direct link: https://github.com/scummvm/scummvm/archive/d04667e58a889e4744f36fb5797a69fa437a1abf.zip). On top of that revision, it has been patched with the "full_patch.diff" (included in this directory's parent) The entire source directory is also included in "Source" in the parent directory, including the dists/pegasus directory missing from the patch.

This is a cutdown ScummVM build because Pegasus Prime does not need many of the usual features of ScummVM.

I've attached a copy of the full_patch.diff file to the post for good measure.
Also I notice with some curiosity that the provided Read Me lists Linux as a supported OS, which no longer seems to be the case.

comment:4 by lotharsm, 5 months ago

Thanks a lot for the confirmation and for the additional information in form of the full patch file!

comment:5 by lotharsm, 5 months ago

I see that they not just modified the detection tables, but also added some new parts to the engine itself. I'll see how this can be backported to the main scummvm tree, but it might take some time to get resolved.

comment:6 by bgK, 5 months ago

This is a duplicate of these issues: https://bugs.scummvm.org/ticket/10347 and https://bugs.scummvm.org/ticket/10622.

This branch should be mostly ready to merge, provided nobody involved disagrees: https://github.com/bgK/scummvm/tree/pegasus-dvd.

comment:7 by bluegr, 5 months ago

Thanks for porting the DVD version patch bgK! I remember that clone2727 was working on the changes of the DVD version, which look to be substantial.

The patch does have a nasty hack (marked accordingly), and it includes CoreServices.h directly for OS X. Other than these two, the patch looks good :)

comment:8 by bgK, 5 months ago

I removed the leftover macos include. I'd prefer not to touch to the hack as I wouldn't know what to do with it.

I did some engine-wide fixes a while back that are already in master. This branch contains also contains the DVD version specific corresponding code patches.

comment:9 by bluegr, 5 months ago

Great! Please create a pull request

comment:10 by bgK, 5 months ago

To be fair, I'm not sure creating a pull request straight away is the way to go. I would like to avoid repeating what happened to the buried engine, as the situation is similar.

comment:11 by sev-, 5 months ago

Creating a pull request is fine. The code is published and the author (Keith) even present in our credits, so including this patch if we want is exactly in the spirit of the GPLv2, and the reason why our project is under this license.

comment:12 by Thunderforge, 5 weeks ago

Game: Journeyman Project Pegasus Prime
Note: See TracTickets for help on using tickets.