Opened 5 months ago

Closed 5 months ago

#10966 closed defect (fixed)

SCI: QFG4: Revenant money-randomness is broken

Reported by: sluicebox Owned by: sluicebox
Priority: normal Component: Engine: SCI
Keywords: original has-pull-request Cc:
Game: Quest for Glory 4

Description

Searching the body of a revenant always awards 15 kopeks instead of the intended 15 to 40. Affects all versions.

The game's script is missing the first parameter to kRandom, so instead of requesting a random number between 0 and 25 and adding 15, the random number generator is reseeded to 25 (which we don't support) and 15 is always used.

To reproduce with attached save from CD version, search the body and then check inventory. This save starts with 30 kopeks and you always end up with 45.

Attachments (1)

gk1-cd.055 (49.7 KB ) - added by sluicebox 5 months ago.

Download all attachments as: .zip

Change History (4)

by sluicebox, 5 months ago

Attachment: gk1-cd.055 added

comment:2 by Filippos Karapetis <bluegr@…>, 5 months ago

In f441ee72:

SCI: Fix QFG4 random revenant kopeks, bug #10966

comment:3 by bluegr, 5 months ago

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.