Opened 5 years ago

Closed 4 years ago

#10951 closed defect (fixed)

SCUMM: ZAK (C64) - flashlight graphics aren't correct to original

Reported by: ATMcashpoint Owned by: sev-
Priority: normal Component: Engine: SCUMM
Version: Keywords: has-pull-request
Cc: Game: Zak McKracken

Description

Similar to the Maniac Mansion ticket I submitted earlier.

In the C64 version of Zak McKracken, when the flashlight is turned on in a dark room, the character sprites are partly lit up. The area lit up by the flashlight beam also has a different shape, with rectangular edges.

The DOS V1 & V2 versions instead turn the character sprites to normal brightness, and that's what ScummVM currently does.

The DOS V1 & V2 versions use two different flashlight beam designs as well, both with rounded edges. ScummVM's implementation is based on the DOS V2 version. Which means its handling of the DOS V1 flashlight beam is probably incorrect as well.

To reproduce this: unlock Melissa & Leslie; get into the Mars Hostel (using token from monolith & fuse from van to repair door); get the flashlight from the hostel locker; get into the Mars Face (using ladder from hostel & combination from African shaman in Kinshasa), unlock door to dark maze (using ladder, push crystal sphere next to door 1 in Great Chamber). As Melissa, enter the dark maze, then turn on the flashlight.

This is as of the April 25, 2019, daily build. Zak McKracken C64, English, running on Windows 10, build 1803, 64-bit.

Attachments (9)

zak-v1-c64.s47 (6.7 KB ) - added by ATMcashpoint 5 years ago.
zakc64flashlight.png (4.4 KB ) - added by ATMcashpoint 5 years ago.
zakc64flashlight1.png (5.0 KB ) - added by ATMcashpoint 5 years ago.
zakc64flashlight3.png (4.4 KB ) - added by ATMcashpoint 5 years ago.
zakc64flashlight3a.png (5.2 KB ) - added by ATMcashpoint 5 years ago.
zakc64scummvmflashlight.png (10.0 KB ) - added by ATMcashpoint 5 years ago.
zakc64scummvmflashlight1.png (8.1 KB ) - added by ATMcashpoint 5 years ago.
zakv1dosflashlight1.png (10.9 KB ) - added by ATMcashpoint 5 years ago.
zakv2dosflashlight1.png (9.4 KB ) - added by ATMcashpoint 5 years ago.

Download all attachments as: .zip

Change History (14)

by ATMcashpoint, 5 years ago

Attachment: zak-v1-c64.s47 added

by ATMcashpoint, 5 years ago

Attachment: zakc64flashlight.png added

by ATMcashpoint, 5 years ago

Attachment: zakc64flashlight1.png added

by ATMcashpoint, 5 years ago

Attachment: zakc64flashlight3.png added

by ATMcashpoint, 5 years ago

Attachment: zakc64flashlight3a.png added

by ATMcashpoint, 5 years ago

Attachment: zakc64scummvmflashlight.png added

by ATMcashpoint, 5 years ago

by ATMcashpoint, 5 years ago

Attachment: zakv1dosflashlight1.png added

by ATMcashpoint, 5 years ago

Attachment: zakv2dosflashlight1.png added

comment:1 by segrax, 5 years ago

Owner: set to segrax

Can confirm, and will work on this with #10947

comment:2 by digitall, 5 years ago

Keywords: has-pull-request added

comment:3 by Filippos Karapetis <bluegr@…>, 5 years ago

In 71172add:

SCUMM: Original V0-V2 flashlight shape and size for MM/Zak (#10947, #10951)

comment:4 by raziel-, 4 years ago

Summary: ZAK-V1: flashlight graphics aren't correct to originalSCUMM: ZAK (C64) - flashlight graphics aren't correct to original

@bluegr

If i understand correctly the fix for this issue has been merged on May 5, 2019.

Can this be closed?

comment:5 by sev-, 4 years ago

Owner: changed from segrax to sev-
Resolution: fixed
Status: newclosed

This was implemented

Note: See TracTickets for help on using tickets.