Opened 8 months ago

Closed 8 months ago

#10909 closed defect (fixed)

[GLK-Frotz] Wrong Capitalized gameIDs in the frotz engine

Reported by: goodoldgeorge Owned by: dreammaster
Priority: normal Component: Engine: GLK
Keywords: Cc:
Game: GLK Z-Code (Frotz) Game

Description

ScummVM version: ScummVM 2.1.0git4858-g08ae52608c-dirty (Mar 4 2019 05:26:08)
Features compiled in: TAINTED Vorbis FLAC MP3 RGB zLib MPEG2 FluidSynth Theora AAC FreeType2 JPEG PNG cloud (servers, local)
OS: Windows 10 build 1809 64-bit

When i running the following games, the ScummVM stops with the following error messages:

Zorkita: WARNING: zorkita is an invalid gameid. Use the --list-games option to list supported gameid!
Celos: WARNING: celos is an invalid gameid. Use the --list-games option to list supported gameid!
Cerillera: WARNING: cerillera is an invalid gameid. Use the --list-games option to list supported gameid!

The entries of these games in the scummvm.ini file:
[Zorkita]
description=Zork I: Il Grande Impero Sotterraneo (000031/Italian)
extra=000031
path=H:\Games\
gameid=zorkita
language=it
filename=Zork-I-Ita.z5
guioptions=sndNoSubs sndNoMusic sndNoSpeech sndNoSFX

[Celos]
description=Un Asunto de Celos (010403/Spanish)
extra=010403
path=H:\Games\
gameid=celos
language=es
filename=Celos.z5
guioptions=sndNoSubs sndNoMusic sndNoSpeech sndNoSFX

[Cerillera]
description=La Pequena Cerillera (101213/Spanish)
extra=101213
path=H:\Games\
gameid=cerillera
language=es
filename=Cerillera.zblorb
guioptions=sndNoSubs sndNoMusic sndNoSpeech sndNoSFX

The game entries in the scummvm.ini file were made with capitalized formats, however, the gameid's were written in lowercase. So It seems the ScummVM doesn't recognize these games.

I think, Should change the following lines in the engines\glk\frotz\detection_tables.h file

Line 925:
{ "Zorkita", "Zork I: Il Grande Impero Sotterraneo" },
for this lowercase format:
{ "zorkita", "Zork I: Il Grande Impero Sotterraneo" },

Line 37 and 38:
{ "Celos", "Un Asunto de Celos" },
{ "Cerillera", "La Pequena Cerillera" },
for these lines in lowercase format:
{ "celos", "Un Asunto de Celos" },
{ "cerillera", "La Pequena Cerillera" },

Change History (1)

comment:1 by dreammaster, 8 months ago

Owner: set to dreammaster
Resolution: fixed
Status: newclosed

Thanks for that. I've committed the fixes

Note: See TracTickets for help on using tickets.