BACKENDS: WIN32 - In-build Add Game Screen doesn't work

[GermanTribun]

Using the newest snapshot, when I try to add a new game, the GUI for selecting the directory with the game files doesn't render and it snaps back to Windows to open up a standard window from which I can choose properly. After that, things are back to normal.

This does not depend on the theme and looking at the program window shows garbage in it while the Windows GUI is open. I parked the snapshot in a different directory from my main SCUMMVM, so that it doesn't mix.

[digitall]

This is not a bug. The ability to use the system native file chooser was added by and was made default true, which might have been a mistake given that this is not yet an option in the GUI to set this:
​https://github.com/scummvm/scummvm/pull/1414

You can disable this by adding:
gui_browser_native=false

to the [scummvm] section of your scummvm.ini file...

[digitall]

The bug really should be to set this to false by default, add an option in the GUI to change this and look at if we can stop the main scummvm window getting "garbage" as the rendering loop is suspended during the native dialog display.

Will assign to criezy who was going to look at this.

[criezy]

I already added the option to the GUI (commits 319b90f and e7ba15f). Does it not show up on Windows? It should be in the Misc tab.

And it would indeed be better if the ScummVM window still rendered properly while the system directory chooser is shown (and by the way it does on macOS I believe).

[digitall]

Ah, Mea Culpa. I hadn't realised that that feature was not compiled for my platform i.e. Linux x86_64 and thought that the GUI option for setting it was missing in all cases.

Will wait on the submitter giving feedback on if the option fixes things for them.

[GermanTribun]

New build now has the option for native GUI instead of SCUMMVM GUI for file select. To make things less confusing, it should be turned off by default.

[SupSuper]

Note that the native file picker was the default for OSX users, so you might need different defaults for different platforms.