Opened 5 years ago

Closed 5 years ago

#10845 closed defect (fixed)

QFG4: Reading 3, Cards land on piles and fall through to bottom

Reported by: Vhati Owned by: bluegr
Priority: low Component: Engine: SCI
Version: Keywords: SCI32 Original has-pull-request
Cc: Game: Quest for Glory 4

Description

ScummVM 2.1.0git4278-gd31e37683c (Dec 13 2018 04:20:25)
Windows 7 64bit
QFG4 CD (English)

The fortune teller's third reading goes counter-clockwise dealing pairs of cards: one vertical, then a horizontal one across it.

Two horizontal cards, Strength (west pile) and Death (south pile), initially land on top but then drop through the previous card.

The original interpreter also does this.

File - 5kb MD5 - Full MD5
RESOURCE.000 - 263dce4aa34c49d3ad29bec889007b1c - 1364ba69e3c0abb68cc0170650a56692
RESOURCE.AUD - c39521bffb1d8b19a57394866184a0ca - 71098b9e97e20c8941c0e4812d5f906f
RESOURCE.MAP - aba367f2102e81782d961b14fbe3d630 - 801a04cc6aa5d437681a2dd0b6545248
RESOURCE.SFX - 3cf95e09dab8b11d675e0537e18b499a - 7c858d7253f86dab4cc6066013c5ecec

Attachments (1)

Screenshot (CD) - Reading 3.png (17.5 KB ) - added by Vhati 5 years ago.
Screenshot (CD) - Reading 3

Download all attachments as: .zip

Change History (6)

by Vhati, 5 years ago

Screenshot (CD) - Reading 3

comment:1 by Vhati, 5 years ago

Occurs in the floppy edition under ScummVM, and its original interpreter, too.


QFG4 Floppy 1.1a + note patch (English)

File - 5kb MD5 - Full MD5
RESOURCE.000 - f64fd6aa3977939a86ff30783dd677e1 - ff42260a665995a85aeb277ad80aac8a
RESOURCE.MAP - d10a4cc177d2091d744e2ad8c049b0ae - 3695b1b0a1d15f3d324ea9f0cc325245
RESOURCE.SFX - 3cf95e09dab8b11d675e0537e18b499a - 7c858d7253f86dab4cc6066013c5ecec

comment:2 by Vhati, 5 years ago

Quick and dirty way to skip to reading 3.

  • Create a new character.
  • Set plot flags for having seen previous readings (297, 298).
    • vv g 518 96
  • Teleport into the tarot room.
    • room 475

comment:3 by Vhati, 5 years ago

script 475 - sThirdReading::changeState()

(2 (localproc_1cfb))
(3
	# "Queen of Swords", Center, Vertical (Wrong view number, see: #10824)
	(= loc0_myCardView 1009)
	(= loc2_myCardPile 1)
	(g0_hero setScript: sShowCard self)
)
(4
	(loc1_myCard setPri: 0)
	(g91_gloryMessager say: 1 6 31 0 self)
)

(5 (localproc_1cfb))
(6
	# "Eight of Swords", West, Vertical
	(= loc0_myCardView 1015)
	(= loc2_myCardPile 2)
	(g0_hero setScript: sShowCard self)
)
(7
	(loc1_myCard setPri: 1)
	(g91_gloryMessager say: 1 6 32 0 self)
)

(8 (localproc_1cfb))
(9
	# "Strength", West, Horizontal
	(= loc0_myCardView 1020)
	(= loc2_myCardPile 2)
	(g0_hero setScript: sShowCard self)
)
(10
	(loc1_myCard setPri: 0)
	(g91_gloryMessager say: 1 6 33 0 self)
)

(11 (localproc_1cfb))
(12
	# "The Magician", South, Vertical
	(= loc0_myCardView 1001)
	(= loc2_myCardPile 3)
	(g0_hero setScript: sShowCard self)
)
(13
	(loc1_myCard setPri: 1)
	(g91_gloryMessager say: 1 6 34 0 self)
)

(14 (localproc_1cfb))
(15
	# "Death", South, Horizontal (Wrong view number, see: #10823)
	(= loc0_myCardView 1018)
	(= loc2_myCardPile 3)
	(g0_hero setScript: sShowCard self)
)
(16
	(loc1_myCard setPri: 0)
	(g91_gloryMessager say: 1 6 35 0 self)
)

(17 (localproc_1cfb))
(18
	# "Ten of Clubs", East, Vertical
	(= loc0_myCardView 1022)
	(= loc2_myCardPile 4)
	(g0_hero setScript: sShowCard self)
)
(19
	(loc1_myCard setPri: 1)
	(g91_gloryMessager say: 1 6 36 0 self)
)

(20 (localproc_1cfb))
(21
	# "Two of Cups", East, Horizontal
	(= loc0_myCardView 1023)
	(= loc2_myCardPile 4)
	(g0_hero setScript: sShowCard self)
)
(22
	(loc1_myCard setPri: 2)
	(g91_gloryMessager say: 1 6 37 0 self)
)
  • Center
    • 0 "Queen of Swords"
  • West
    • 1 "Eight of Swords"
    • 0 "Strength"
  • South
    • 1 "The Magician"
    • 0 "Death"
  • East:
    • 1 "Ten of Clubs"
    • 2 "Two of Cups"

Looks like someone got confused alternating 0 and 1, forgetting that the center pile only had one card. Each pile should start with 0 and increment. "Two of Cups" is weird, but at least it's higher.

comment:4 by Vhati, 5 years ago

Keywords: has-pull-request added

Pull Request: SCI32: Fix QFG4 tarot readings

comment:5 by bluegr, 5 years ago

Owner: set to bluegr
Resolution: fixed
Status: newclosed

Thanks for your work! The pull request has been merged, so this can be closed now

Note: See TracTickets for help on using tickets.