WIN32: scummvm.exe FileDescription is a url

[Vhati]

The FileDescription in ScummVM's executable is unusual: a url.

Windows sometimes uses FileDescription in dialogs assuming it is a proper name.
Not ProductName as one might expect.

Spot checks among other apps indicates those two values are often identical. Sometimes FileDescription will be a slightly longer name.

I have not seen another executable with a url in any field of its metadata.

[Vhati]

I'm guessing this is the relevant file.


​Source: dists/scummvm.rc

BLOCK "StringFileInfo"
BEGIN
    BLOCK "040904b0" // US English, Unicode
    BEGIN
        VALUE "Comments", "Look! A three headed monkey (TM)! .. Nice use of the TM!\0"
        VALUE "CompanyName", "scummvm.org\0"
        VALUE "FileDescription", "http://www.scummvm.org/\0"
        VALUE "FileVersion", SCUMMVM_VERSION "\0"
        VALUE "InternalName", "scummvm\0"
        VALUE "LegalCopyright", "Copyright © 2001-2018 The ScummVM Team\0"
        VALUE "LegalTrademarks", "'SCUMM', and all SCUMM games are a TM of LucasArts. Simon The Sorcerer is a TM of AdventureSoft. Beneath a Steel Sky and Broken Sword are a TM of Revolution. Flight of the Amazon Queen is a TM of John Passfield and Steve Stamatiadis. \0"
        VALUE "OriginalFilename", "scummvm.exe\0"
        VALUE "ProductName", "ScummVM\0"
        VALUE "ProductVersion", SCUMMVM_VERSION "\0"
    END
END

[lotharsm]

Thanks for pointing that out!

Fixed in ​https://github.com/scummvm/scummvm/commit/a5881103562a7d3484107887a1084e1e2316c469.