Opened 3 months ago

Last modified 3 months ago

#10815 new defect

SCI: Incorrect list of supported games

Reported by: rtentser Owned by:
Priority: normal Component: Engine: SCI
Keywords: has-pull-request Cc:
Game:

Description

$ ./configure --disable-all-engines --enable-engine=sci
[…]
$ scummvm -v
ScummVM 2.1.0git3940-g97e2da5ae9 (Nov 22 2018 16:13:06)
Features compiled in: Vorbis FLAC MP3 ALSA SEQ sndio TiMidity RGB zLib MPEG2 FluidSynth Theora AAC FreeType2 JPEG PNG cloud (servers)
$ scummvm -z
Game ID Full Title


sci Sierra SCI Game

Change History (8)

comment:1 Changed 3 months ago by rtentser

Component: --Unset--Engine: SCI

comment:2 Changed 3 months ago by rtentser

$ scummvm -z
Game ID              Full Title                                            
-------------------- ------------------------------------------------------
sci                  Sierra SCI Game

comment:3 Changed 3 months ago by digitall

Was not sure if this was a regression, so have tested v1.9.0, v1.8.0, v1.5.0 and back to v1.2.0 which was the first release with the SCI engine. This has always been the same behaviour from scummvm -z.

Not sure if this is correct or not. I thought that this output should list all PlainGameDescriptors for compiled / plugged-in engines, but I may be wrong on that.

comment:4 Changed 3 months ago by rtentser

When i tried it with pink engine, it showed two supported games with right ids.

Last edited 3 months ago by rtentser (previous) (diff)

comment:5 Changed 3 months ago by digitall

Hmm. I wondered if this was related to singleId in the detector and the issues with gameid. See this PR which is proposing engineid as a fix for this:
https://github.com/scummvm/scummvm/pull/1210

But despite SCI engine supporting a large number of games, I don't think it is using singleId.

Will have to do some testing and check through code to work out what is going on and why.

comment:6 Changed 3 months ago by bluegr

SCI does use a single game ID (_singleId is set in SciMetaEngine), and this behavior is what pull request #1210 should resolve.

comment:7 Changed 3 months ago by digitall

Ah sorry... missed the code line previously:
https://github.com/scummvm/scummvm/blob/master/engines/sci/detection.cpp#L558

Yes, that explains this "bug".

comment:8 Changed 3 months ago by digitall

Keywords: has-pull-request added
Note: See TracTickets for help on using tickets.