Opened 5 years ago

Closed 4 years ago

#10815 closed defect (fixed)

SCI: Incorrect list of supported games

Reported by: rtentser Owned by:
Priority: normal Component: Engine: SCI
Version: Keywords: has-pull-request
Cc: Game:


$ ./configure --disable-all-engines --enable-engine=sci
$ scummvm -v
ScummVM 2.1.0git3940-g97e2da5ae9 (Nov 22 2018 16:13:06)
Features compiled in: Vorbis FLAC MP3 ALSA SEQ sndio TiMidity RGB zLib MPEG2 FluidSynth Theora AAC FreeType2 JPEG PNG cloud (servers)
$ scummvm -z
Game ID Full Title

sci Sierra SCI Game

Change History (9)

comment:1 by rtentser, 5 years ago

Component: --Unset--Engine: SCI

comment:2 by rtentser, 5 years ago

$ scummvm -z
Game ID              Full Title                                            
-------------------- ------------------------------------------------------
sci                  Sierra SCI Game

comment:3 by digitall, 5 years ago

Was not sure if this was a regression, so have tested v1.9.0, v1.8.0, v1.5.0 and back to v1.2.0 which was the first release with the SCI engine. This has always been the same behaviour from scummvm -z.

Not sure if this is correct or not. I thought that this output should list all PlainGameDescriptors for compiled / plugged-in engines, but I may be wrong on that.

comment:4 by rtentser, 5 years ago

When i tried it with pink engine, it showed two supported games with right ids.

Last edited 5 years ago by rtentser (previous) (diff)

comment:5 by digitall, 5 years ago

Hmm. I wondered if this was related to singleId in the detector and the issues with gameid. See this PR which is proposing engineid as a fix for this:

But despite SCI engine supporting a large number of games, I don't think it is using singleId.

Will have to do some testing and check through code to work out what is going on and why.

comment:6 by bluegr, 5 years ago

SCI does use a single game ID (_singleId is set in SciMetaEngine), and this behavior is what pull request #1210 should resolve.

comment:7 by digitall, 5 years ago

Ah sorry... missed the code line previously:

Yes, that explains this "bug".

comment:8 by digitall, 5 years ago

Keywords: has-pull-request added

comment:9 by sluicebox, 4 years ago

Resolution: fixed
Status: newclosed was merged in November and fixed this.

# ./scummvm.exe -z
Game ID                        Full Title
------------------------------ -----------------------------------------------------------
sci:sci                        Sierra SCI Game
sci:sci-fanmade                Fanmade SCI Game
sci:astrochicken               Astro Chicken
sci:christmas1988              Christmas Card 1988
sci:iceman                     Codename: Iceman
sci:camelot                    Conquests of Camelot: King Arthur, Quest for the Grail

Note: See TracTickets for help on using tickets.