Changes between Version 7 and Version 8 of Ticket #10814, comment 17


Ignore:
Timestamp:
Nov 22, 2018, 6:43:55 PM (6 years ago)
Author:
Vhati

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #10814, comment 17

    v7 v8  
    1111Hm. I can't say what QFG4 is expecting from the call. Technically all the OR does is guarantee a non-zero result. So SetNowSeen() could get away with returning a bool, an object address, or void (de facto object, with the call's obj param left unmodified in acc). They'd all be forced to evaluate as true and not abandon the if block.
    1212
    13 If SetNowSeen() is returning void (de facto object), and if that is intended behavior for QFG4, then the invalid-arithmetic detection would be a false positive. Everywhere this OR idiom is used.
     13If SetNowSeen() is returning void (de facto object), and if that is intended behavior for QFG4, then the invalid-arithmetic detection would be a false positive. Everywhere this "(| (SetNowSeen blah) $0001)" idiom is used.