Opened 11 months ago

Last modified 11 months ago

#10810 new defect

Graphics: Return to Launcher changes fullscreen/windowed mode

Reported by: sluicebox Owned by:
Priority: normal Component: Graphics
Keywords: has-pull-request Cc:
Game:

Description

It would be nice if Return to Launcher didn't change full-screen/windowed mode. It doesn't seem intentional and kicks me out of full screen a lot.

You get kicked out of full screen mode if you:

  1. Start in windowed mode
  2. Switch to full screen with a hotkey
  3. Return to Launcher from a game

This if happens if the "fullscreen" config setting is false but not if the fullscreen setting doesn't exist, which means there's three different behaviors: Full screen checked, unchecked, and you've never once used the Options screen. The opposite also occurs, if fullscreen=true and you switch to window and return to launcher it will switch back to full screen.

This is because setupGraphics() is called again when returning to launcher and contains:

if (ConfMan.hasKey("fullscreen"))
	system.setFeatureState(OSystem::kFeatureFullscreenMode, ConfMan.getBool("fullscreen"));

It seems like setupGraphics() should only set kFeatureFullscreenMode on its first run. I did a quick and dirty patch to try that out and it worked for me on Win7.

For now I just manually delete the fullscreen line from my config file.

Change History (3)

comment:2 by digitall, 11 months ago

Keywords: has-pull-request added

comment:3 by macca8, 11 months ago

The existing code is fine. Basically, it’s all about preference rankings.
You’ve already identified the solution… remove the fullscreen setting from the Config File.

Rather than repeat myself, I’ve posted a comment in your https://github.com/scummvm/scummvm/pull/1415#issuecomment-443138388 which discusses this further and suggests a potential fix.

Note: See TracTickets for help on using tickets.