#10781 closed defect (fixed)
SCI: GK1: French/Spanish CD SysLogger hotkey
Reported by: | sluicebox | Owned by: | sluicebox |
---|---|---|---|
Priority: | normal | Component: | Engine: SCI |
Version: | Keywords: | has-pull-request | |
Cc: | Game: | Gabriel Knight 1 |
Description
This one's weird.
French and Spanish CD versions contain an active debugging hotkey, ALT+N, which brings up a series of unskippable bug-reporting dialogs and eventually writes files to disk and crashes non-release builds of ScummVM due to an uninitialized read. This hotkey is always active and not hidden behind the game's debug mode flag. I'm submitting a script patch to just disable it.
English and German CD versions didn't ship with this hotkey script, none of the floppies either as far as I can tell. Screenshot attached.
Attachments (1)
Change History (6)
by , 6 years ago
Attachment: | syslogger.png added |
---|
comment:1 by , 6 years ago
comment:2 by , 6 years ago
You don't happen to be an old Sierra developer? :p
I really wonder how you figure all of these issues out.
Very nice work once again.
We could of course also add a workaround for the uninitialized read, but I guess no one really needs this functionality.
comment:3 by , 6 years ago
Keywords: | has-pull-request added |
---|
comment:4 by , 6 years ago
Owner: | set to |
---|---|
Resolution: | → fixed |
Status: | new → closed |
The pull request has been merged now, so this can be closed. Nice work! :)
comment:5 by , 3 years ago
Owner: | changed from | to
---|
https://github.com/scummvm/scummvm/pull/1366