Opened 12 months ago

Closed 12 months ago

Last modified 12 months ago

#10746 closed defect (fixed)

SHERLOCK: RT: Loading From GMM during Intro Prolog Causes Mouse Cursor To Get Stuck Hidden

Reported by: Kroc Owned by: digitall
Priority: high Component: Engine: Sherlock
Keywords: mouse Cc:
Game: Sherlock Holmes: Case of the Rose Tattoo

Description

Have a save game present, anywhere will do.

Under normal circumstances, the game will not let you skip the title screen until the "Rose Tattoo" logo begins spinning. During this time the mouse cursor is invisible.

In the original game you would press ESC and then can load the game from the menu once Doctor Watson is standing outside 221B Baker St.

If you press CTRL+F5 to bring up the menu during the title screen period / intro where the mouse pointer is invisible and then load a save-game, the mouse pointer will remain invisible.

Fix: Forcibly make the mouse-pointer visible after any load.

Change History (4)

comment:1 by digitall, 12 months ago

Kroc: Thanks for the bug report. The other solution for this and probably the better one is to disallow load/save from the GMM until the title screen finishes or is skipped.

comment:2 by digitall, 12 months ago

Hmm...
http://wiki.scummvm.org/index.php/Advanced_Engine_Features#Loading.2FSaving_during_run_time

I think I can see the issue here. The Tattoo subengine is missing an implementation of canLoadGameStateCurrently(). It does have the save equivalent:
https://github.com/scummvm/scummvm/blob/master/engines/sherlock/tattoo/tattoo.h#L108

It is inheriting from the base engine, but that does not account for the prolog:
https://github.com/scummvm/scummvm/blob/master/engines/sherlock/sherlock.cpp#L268

Will implement this and commit...

comment:3 by digitall, 12 months ago

Owner: set to digitall
Resolution: fixed
Status: newclosed

Fixed in commit 15306581ab27c0ea9605b7d3909262b70226954c.

Have already done a basic test and this seems fine.

@Kroc: This will be included in the next nightly build.

Closing as fixed.

comment:4 by digitall, 12 months ago

Summary: Mouse pointer remains invisible if load is invoked via CTRL+F5 before escaping title screenSHERLOCK: RT: Loading From GMM during Intro Prolog Causes Mouse Cursor To Get Stuck Hidden
Note: See TracTickets for help on using tickets.