Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#10745 closed defect (fixed)

SCI: GK1: No such "Spanish Windows CD" version

Reported by: sluicebox Owned by: digitall
Priority: normal Component: Engine: SCI
Keywords: Cc:
Game: Gabriel Knight 1

Description

"Gabriel Knight - Spanish Windows CD" should be removed from the detection table as it's DOS-only. All the localized versions are DOS-only, only the English versions are dual-mode. Maybe they couldn't easily localize their Windows components?

What this means for users is that selecting Windows when prompted results in no videos during the game as there are no AVI files to play.

I have this version with the same VERSION from the comments: 1.000.000 / Gabriel Knight 1 / Spanish CD / April 13, 1995

Weird trivia: rm371:init (nightmare scenes) on localized CDs tests the current day incorrectly, preventing it from playing the right nightmare AVIs, but since that code only runs when the platform isn't DOS and they're all DOS-only the bug is moot.

Change History (7)

comment:1 Changed 6 months ago by digitall

Looking at the code, you are referring to this entry which was submitted according to comments by jvprat:
https://github.com/scummvm/scummvm/blob/master/engines/sci/detection_tables.h#L825

comment:2 Changed 6 months ago by digitall

git blame lists that this was added as SVN r47670 which is commit f7a72c897a9657320ccd6a32873b364f77412e98:
https://github.com/scummvm/scummvm/commit/f7a72c897a9657320ccd6a32873b364f77412e98

The commit message of that reads:
Add duplicate entries of GK1 CD with the Windows platform set so that setting the platform to Windows won't appear as a missing entry.

Last edited 6 months ago by digitall (previous) (diff)

comment:3 Changed 6 months ago by digitall

Ah, check the IRC log from that day which covers why this was done:
http://logs.scummvm.org/log.php?log=scummvm.log.29Jan2010&format=html

See the comment from salty-horse at 14:01 and then read through until the commit of r47670 at 15:37 for context.

I am not sure of the impact of removing those three detection entries added in r47670. Would need to check with a SCI / SCI32 engine developer and work out if these can now be removed or if the issue indicated by salty-horse can be fixed in a better / more correct way.

comment:4 Changed 6 months ago by sluicebox

I think this is simpler than that. You've already removed one of those three entries (German Windows CD) from that first commit because it was wrong. I'm just saying that Spanish Windows CD should also be removed for the same reason. This would make all three localized CD versions (French/German/Spanish) consistent in the detection tables. Right now Spanish CD is the only one with the extra Windows entry even though it's the same as the other localized CDs.

The English versions are correct (DOS and Windows)

The IRC chat from 2010 was long before SCI32 got finished and high-res now works just fine with DOS-only versions, it's even the default when you add one to ScummVM, so the existence of Spanish Windows CD isn't keeping anything working, it just looks like it didn't get removed with the German Windows CD entry.

comment:5 Changed 6 months ago by digitall

Ah OK. I see what you mean now by comparing that to the current state of the detection tables.

I see that the German Windows entry was removed in commit 02a7f331b110dc0a5b5df39a6a89ada45aa96101:
https://github.com/scummvm/scummvm/commit/02a7f331b110dc0a5b5df39a6a89ada45aa96101

OK. Will remove the Spanish Windows as you indicate...

comment:6 Changed 6 months ago by digitall

Owner: set to digitall
Resolution: fixed
Status: newclosed

Removed entry in commit 1e5f34c02789eb2a3bda87d122ff1ce26811e67b.

Closing as fixed.

comment:7 Changed 6 months ago by sluicebox

Thank you! I've been gathering versions of GK1 to go bug hunting and it's tricky to sort out which versions do what.

Note: See TracTickets for help on using tickets.