Changes between Version 1 and Version 2 of Ticket #10734, comment 1


Ignore:
Timestamp:
05/31/20 01:19:25 (20 months ago)
Author:
sluicebox

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #10734, comment 1

    v1 v2  
    1 I've narrowed this down some.
    2 
    3 Sound 123 (pry vault) and sound 126 (turn crank) have two channels:
    4 
    5 {{{
    6 channel         flags
    7 00              30
    8 09              0F
    9 }}}
    10 
    11 
    12 Neither of these channels has the Adlib flag 04 set and so neither are played by ScummVM when using Adlib, but the original Adlib driver does play this channel. At least, it does for these sounds.
    13 
    14 To test this, I changed MidiPlayer_Adlib::hasRhythmChannel() to return true, causing channel 9 to be played. Both sounds played correctly as they do in the original.
    15 
    16 So now the question is why does Sierra's Adlib driver play this?
     1PR with better description: https://github.com/scummvm/scummvm/pull/2293