Opened 14 months ago

Closed 5 months ago

#10711 closed defect (fixed)

QFG4: Lockup after defeating a Wraith

Reported by: darksoul42 Owned by: sluicebox
Priority: low Component: Engine: SCI
Keywords: sci32 has-pull-request Cc:
Game: Quest for Glory 4

Description

On this version of ScummVM:
ScummVM 2.1.0git (Sep 9 2018 17:36:39)
Features compiled in: Vorbis FLAC MP3 ALSA SEQ TiMidity RGB zLib MPEG2 FluidSynth Theora AAC FreeType2 JPEG PNG

Closely related to #10710, after defeating the Wraith, I noticed my character stuck and the Wraith disappearing animation never kicking in. Weirder yet, just after defeating it, I was stuck (but time would still go on, and dawn would progress), so I saved in that state, but upon reloading I would actually see the locked up Wraith.

I wonder if it's either a timing issue with the "Wraith dying" event, or a problem related to the position of the Hero.

Attachments (1)

qfg4-cd.008 (43.5 KB ) - added by darksoul42 14 months ago.
Just after defeating a Wraith, but the disappearing does not trigger, and the Hero can't move anymore

Download all attachments as: .zip

Change History (7)

by darksoul42, 14 months ago

Attachment: qfg4-cd.008 added

Just after defeating a Wraith, but the disappearing does not trigger, and the Hero can't move anymore

comment:1 by bluegr, 13 months ago

Priority: normallow

This is a bug with the NRS patch - after fighting a wraith, the game locks up:
http://www.questformoreglory.com/history/index.php?showtopic=2521

The solution is to delete 53.scr and 53.hep (part of the NRS patch) from the game's folder.

A better solution is to fix the issues in the NRS patch in ScummVM, like with the other games where we fixed them in a similar fashion.

comment:2 by bluegr, 12 months ago

I'm keeping this one open till we blacklist this patch, to avoid getting new bug reports about it on the future

comment:3 by Vhati, 12 months ago

@bluegr:
Question: Would it be uncomplicated for a GOG player to transition to ScummVM?
Are there unpatching guides? Or instructive error messages to walk them through it?
I'd like to recommend it to someone but don't wanna leave a bad first impression.


Thread: GOG Forum - m-kiewitz

All sorts of GOG patch files related to [QFG] are quite broken, that's also why the GOG version doesn't work properly in ScummVM, because we do all sorts of security checks. The original interpreter checked almost nothing, which means that broken patches may still work somewhat. You can remove those script patches though and then it will work in ScummVM.
[...]
GOG uses Dos-Box for Quest for Glory, which then uses the original Sierra SCI interpreter. Because of that they are using all sorts of fan patches to get around timer issues and so on, but those cause other issues.

Version 1, edited 12 months ago by Vhati (previous) (next) (diff)

comment:4 by sluicebox, 5 months ago

Keywords: has-pull-request added
Owner: set to sluicebox

Simple script patch to fix the signed/unsigned bug in the NRS patch:

https://github.com/scummvm/scummvm/pull/1700

This prevents the bug and unfreezes the attached save game.

comment:5 by Filippos Karapetis <bluegr@…>, 5 months ago

In 08a7b6fd:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:6 by bluegr, 5 months ago

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.