QFG4: Lockup after defeating a Wraith

[darksoul42]

On this version of ScummVM:
ScummVM 2.1.0git (Sep 9 2018 17:36:39)
Features compiled in: Vorbis FLAC MP3 ALSA SEQ TiMidity RGB zLib MPEG2 FluidSynth Theora AAC FreeType2 JPEG PNG

Closely related to #10710, after defeating the Wraith, I noticed my character stuck and the Wraith disappearing animation never kicking in. Weirder yet, just after defeating it, I was stuck (but time would still go on, and dawn would progress), so I saved in that state, but upon reloading I would actually see the locked up Wraith.

I wonder if it's either a timing issue with the "Wraith dying" event, or a problem related to the position of the Hero.

[darksoul42]

Just after defeating a Wraith, but the disappearing does not trigger, and the Hero can't move anymore

[bluegr]

This is a bug with the NRS patch - after fighting a wraith, the game locks up:
​http://www.questformoreglory.com/history/index.php?showtopic=2521

The solution is to delete 53.scr and 53.hep (part of the NRS patch) from the game's folder.

A better solution is to fix the issues in the NRS patch in ScummVM, like with the other games where we fixed them in a similar fashion.

[bluegr]

I'm keeping this one open till we blacklist this patch, to avoid getting new bug reports about it on the future

[sluicebox]

Simple script patch to fix the signed/unsigned bug in the NRS patch:

​https://github.com/scummvm/scummvm/pull/1700

This prevents the bug and unfreezes the attached save game.

[Filippos Karapetis <bluegr@…>]

In 08a7b6fd:

SCI32: Fix QFG4 Wraith fan-patch, bug #10711