Opened 6 years ago

Closed 5 years ago

#10710 closed defect (fixed)

QFG4: Crash when trying to parry with a dagger and a Thief with no Parry skill

Reported by: darksoul42 Owned by: bluegr
Priority: normal Component: Engine: SCI
Version: Keywords: sci32 has-pull-request
Cc: Game: Quest for Glory 4

Description

On this version of ScummVM:
ScummVM 2.1.0git (Sep 9 2018 17:36:39)
Features compiled in: Vorbis FLAC MP3 ALSA SEQ TiMidity RGB zLib MPEG2 FluidSynth Theora AAC FreeType2 JPEG PNG

I just started a Thief character with no magic and no parry skill at all, and tried to fight a Wraith. When going to strategy mode, it seems it tried to parry but this caused the following error and crash:

WARNING: Uninitialized read for parameter 2 from method CT::init (room 810, script 64992, localCall ffffffff)!
WARNING: Uninitialized read for parameter 2 from method CT::init (room 810, script 64992, localCall ffffffff)!
ERROR: Invalid arithmetic operation (bitwise OR - params: 0035:1999 and 0000:0001) from method xParryLow::doit (room 810, script 41, localCall ffffffff)!

Strangest was that it seems possible to parry without crashing when doing it by hand.

Attachments (1)

qfg4-cd.007​ (38.9 KB ) - added by darksoul42 6 years ago.
Just before fighting the Wraith

Download all attachments as: .zip

Change History (3)

by darksoul42, 6 years ago

Attachment: qfg4-cd.007​ added

Just before fighting the Wraith

comment:1 by digitall, 5 years ago

Keywords: has-pull-request added

​Pull Request: SCI32: Fix QFG4 conditional void calls

comment:2 by bluegr, 5 years ago

Owner: set to bluegr
Resolution: → fixed
Status: new → closed

Thanks for your work! The pull request has been merged, so this can be closed now

Note: See TracTickets for help on using tickets.