Opened 7 months ago

Last modified 5 months ago

#10708 pending enhancement (fixed)

Unknown game variant: Danish Pink Panther: Passport to Peril localisation

Reported by: Duffadash Owned by: whiterandrek
Priority: normal Component: Engine: Pink
Keywords: pink panther, passport to peril, peril-nl, danish, den lyserøde panter, hemmelig mission i udlandet Cc: whiterandrek
Game: Pink Panther: Passport to Peril

Description

Tried testing if the Danish localised version of Pink Panther: Passport to Peril worked yet.
The game was called "Den lyderøde panter: På hemmelig mission i udlandet" and localised to Danish by Funsoft Danmark.
I know that the sequel was also localised although I sadly do not own a copy myself.

ScummVM version is the latest daily for Windows 64-bit (2.1.0git3692-g03a6f34dc2)

Matched game IDs for the Pink Panther Engine engine: peril-nl

{"PPTP.ORB", 0, "eae050c09d7f6bfbb3166d2c39957e31", 608976918],

https://i.imgur.com/ord8kS9l.jpg
https://i.imgur.com/0M7ZTGWl.jpg
https://i.imgur.com/T0l6DDFl.jpg

Change History (11)

comment:1 Changed 6 months ago by digitall

Component: --Other--Engine: Pink

comment:2 Changed 6 months ago by whiterandrek

Owner: set to whiterandrek

Can't fix this for now
ScummVm doesn't support Danish language

comment:3 Changed 6 months ago by digitall

@whiterandrek: Not quite sure what you mean. Do you mean that we need to add some kind of language support to common code, or do you mean that the PINK engine will need work to support this? Just that a large number of other localised versions are present in the detection tables so just asking if there is a specific blocker for Danish.

comment:4 Changed 6 months ago by criezy

If we want the correct language to be used in the detection entry, we will need to add Danish to the Language enum in common/language.h (and LanguageDescription in common/language.cpp), but that should be trivial. Like @digitall, I am curious to know if there is a more serious blocker that would require work on the engine itself.

comment:5 Changed 6 months ago by digitall

Since adding the symbols to Common::Language for Danish is pretty trivial, I have done this in commit d0480e2dadba65722cca9c84ff62366b2362fe71.

@whiterandrek: I assume that a detection entry will be required in the PINK engine at least. Can you do that and then the user can provide feedback i.e. mark it ADGF_UNSTABLE if it is likely to require work / testing to support without bugs.

comment:6 Changed 6 months ago by whiterandrek

I meant support in Common code.

The game will work, but with menu and pda problems, because MacText doesn't support unicode.

comment:7 Changed 6 months ago by digitall

@whiterandrek: Thanks for response. Well, this should now be fixed in Common::Language so can you add unstable entry for Danish variant and any required engine code... We can then look at how to support Unicode at least in a restricted sense in MacText...

comment:8 Changed 6 months ago by whiterandrek

Resolution: fixed
Status: newpending

comment:9 Changed 6 months ago by digitall

@whiterandrek: Thanks for sorting that. I assume this is pending as MacText needs Unicode support?
https://github.com/scummvm/scummvm/blob/master/graphics/macgui/mactext.h#L89

Any idea if we have a Danish developer who could look at this?

comment:10 in reply to:  9 Changed 6 months ago by whiterandrek

Replying to digitall:

@whiterandrek: Thanks for sorting that. I assume this is pending as MacText needs Unicode support?
https://github.com/scummvm/scummvm/blob/master/graphics/macgui/mactext.h#L89

Any idea if we have a Danish developer who could look at this?

Problem with not Danish language. The problem with all versions except English.
Better to create another ticket.

comment:11 Changed 5 months ago by digitall

Game: Pink Panther: Passport to Peril
Note: See TracTickets for help on using tickets.