Opened 4 months ago

Closed 5 weeks ago

#10664 closed defect (fixed)

GROOVIE: T7G: Loading crashes during some puzzles

Reported by: dafioram Owned by: digitall
Priority: normal Component: Engine: Groovie
Keywords: Cc:
Game: 7th Guest

Description

Game: T7G GOG
ScummVM: 2.1.0git-3171-gad3feae490 (Aug 4)

This was allowed once saving/loading with the gmm was added to the code.

When trying to load a saved game using the GMM while a puzzle is interactive will cause a crash in some puzzles. I don't know enough about the engine to know when a puzzle is running, but that could be added to the canLoadCurrently function if that was understood. Currently, it just checks to see if _script is non-zero.

Saving using the GMM works just fine everywhere I tried.

The game can just be loaded to that save so not a big deal.

Trying to read a script bte at address 0x1757, while the script is just 0x0676 bytes long!

Attachments (1)

t7g.004 (123 bytes) - added by dafioram 4 months ago.
Crypt puzzle

Download all attachments as: .zip

Change History (4)

Changed 4 months ago by dafioram

Attachment: t7g.004 added

Crypt puzzle

comment:1 Changed 4 months ago by dafioram

I went through a few of the puzzles and loaded another save to see if it crashed. Some do and some don't. Yes means it has the crash above and no means nothing happens when you try to load (no crash)

Microscope yes
Knight no
Maze/grate no
Telescope no
Knives no
Attic windows yes
Crypt yes
Queen yes
Bishop no
Matching tiles yes
Portrait. Portrait changes state
Coins different crash
Toy blocks different crash.

comment:2 Changed 5 weeks ago by digitall

Owner: set to digitall
Resolution: fixed
Status: newpending

@daforiam: This should have been fixed by PR 1376 / commit 75c6f2fd609b16d6f122bee8cd7a04e7a300f325 :
https://github.com/scummvm/scummvm/commit/75c6f2fd609b16d6f122bee8cd7a04e7a300f325

Could you do a retest and see if the loading is now working as expected...

Setting to pending submitter feedback.

Last edited 5 weeks ago by digitall (previous) (diff)

comment:3 Changed 5 weeks ago by dafioram

Status: pendingclosed

All of these worked without issue

Note: See TracTickets for help on using tickets.