Opened 3 months ago

Closed 2 weeks ago

#10655 closed defect (fixed)

Errors

Reported by: necros2k7 Owned by: digitall
Priority: normal Component: Tools
Keywords: Cc:
Game:

Description

[devtools\make-scumm-fontdata.c:841]: (error) Common realloc mistake: 'specialCharsetData' nulled but not freed upon failure
[devtools\create_kyradat\pak.cpp:207]: (error) Memory leak: data
[devtools\create_hugo\create_hugo.cpp:866]: (error) Resource leak: outFile
[devtools\create_project\xcode.h:67]: (performance) Function parameter 'fileType' should be passed by const reference.

Change History (5)

comment:1 Changed 2 weeks ago by digitall

First error should be fixed by commit 16bf0e454f831765a59cc6ace4d8a855196778c8.

comment:2 Changed 2 weeks ago by digitall

Second error should be fixed by commit f480bed06db86da15e41c705a9d22e80782c1424

comment:3 Changed 2 weeks ago by digitall

Third error should be fixed by commit 7956c75e8e91e96df075d59152da493d3414d0f8

comment:4 Changed 2 weeks ago by digitall

Not quite sure how to deal with the last performance message i.e. changing the FileProperty() constructor from using std::string to using references...

comment:5 Changed 2 weeks ago by digitall

Owner: set to digitall
Resolution: fixed
Status: newclosed

Ah worked it out.

Fourth performance warning fixed by commit 48ece56bafbcf5e940de6dda759f63dfcab2b57c.

Closing as fixed.

Note: See TracTickets for help on using tickets.