Opened 4 years ago

Closed 9 months ago

#10644 closed defect (fixed)

SCUMM: MI 1+2 (Ultimate Talkie Patch) - preferences keyboard controls no longer function

Reported by: SirFritz Owned by: orgads
Priority: high Component: Engine: SCUMM
Version: Keywords:
Cc: orgads Game: Monkey Island 1

Description

Version ScummVM 2.0.0
Windows 10 x64 1803

In either SoMI or MI2 using their respective ultimate talkie patch, pressing one of the custom keyboard controls to change preferences (such as CTRL-p to change spiffy graphics mode or CTRL-a to change narrator mode) has no effect. The change isn't made and the on-screen text displaying your current setting doesn't show. It works fine in version 1.9.0 and earlier using the same game files and scummvm.ini file. It also doesn't work in 2.1.0 dev build from july 24.

Change History (9)

comment:1 by raziel-, 23 months ago

Summary: Ultimate Talkie Monkey Island preferences keyboard controls no longer functionSCUMM: MI 1+2 (Ultimate Talkie Patch) - preferences keyboard controls no longer function

comment:2 by JiFish, 17 months ago

This doesn't just effect Ultimate Talkie. The famous "CTRL-W" to win the game Easter Egg also doesn't function.

I suggest this bug be renamed "SCUMM: MI 1+2 - In-engine keyboard controls no longer function" (or something to that effect)

I can also confirm this is still broken in 2.2.0.

Last edited 17 months ago by JiFish (previous) (diff)

comment:3 by sev-, 10 months ago

Priority: normalhigh

This would be nice to get fixed before the release.

comment:4 by orgads, 9 months ago

It looks like Ctrl is not passed to the game. If I press Ctrl-P with 1.9, it changes spiffy mode, but with later versions it acts as P (chooses Pick Up action). Same for Ctrl-O which has no effect with 1.9, but with 2.2 it chooses Open.

comment:5 by orgads, 9 months ago

Cc: orgads added

comment:6 by orgads, 9 months ago

I just built 1.9.0 from source (on mingw), and the bug still reproduces. It works as expected with the binary distribution from https://downloads.scummvm.org/frs/scummvm/1.9.0

That's very strange. Maybe it's platform dependent?

comment:7 by orgads, 9 months ago

Owner: set to orgads
Resolution: pending
Status: newpending

comment:9 by sev-, 9 months ago

Resolution: pendingfixed
Status: pendingclosed

The pull request has been merged. The issue is fixed.

Note: See TracTickets for help on using tickets.