MADS: Save game loading assertion

[raziel-]

ScummVM 2.1.0git (Jun 24 2018 20:36:35)
Features compiled in: Vorbis FLAC MP3 RGB zLib MPEG2 Theora AAC FreeType2 JPEG PNG cloud (servers, local)

First off, sorry if there was a change in the save game handling, which i may have missed.

I cannot load any of my previously saved games any more.
I always end up with an assertion
User picked target 'nebular' (gameid 'nebular')...

Looking for a plugin supporting this gameid... MADS Engine
Starting 'Rex Nebular and the Cosmic Gender Bender'

assertion "idx < _size" failed: file "./common/array.h", line 192

Save game attached

Rex Nebular and the Cosmic Gender Bender (DOS/English)

AmigaOS4 - PPC - SDL - BE
gcc (adtools build 5.4.0) 5.4.0

[raziel-]

Save state

[raziel-]

Better use a second one to confirm

[dafioram]

These saves also crash on linux.

How old are they (any idea which scummvm created them)? I wonder if the games are just saved at trouble some save spots in the game (do all of your old saves crash)?

[raziel-]

Must have been 1.7.0, i think those save games were done before or shotly after the implementation of the game.
As i said, i'm not sure if these save games are too old anyway, because the save game handling might have changed in the meantime.
I remember that after the implementation of Rex they still worked (but that may be my memory playing tricks)

All of the save spots were done in a "secure" surrounding, apart some where Rex was diving in the beginning

[raziel-]

...and yes, all of my saves are broken

[bonki]

Is it possible that you created these while MADS was still unstable/under development? The crash even happens with v1.8.0 which was the first version officially supporting the engine.

[bonki]

Forgot to reload the page before posting so didn't see your comments - that probably explains the issue. I compiled several versions (v1.7.0 tags and upwards) and all of them crash when loading your saves.

[bonki]

Scratch that. In v1.7.0 (unsupported) your first save crashes but the second one works, in v1.8.0 (supported) both crash. I'll do a bisect just to be sure but I think it's safe to assume that these are simply too old.

[bonki]

Commit 79fbcb96c3532e730ad8298d96f56f4a52c77ead is responsible for the second savegame crashing. It touches synchronization code which has an impact on savegame handling. The commit is older than v1.8.0 and even e938b4f1350799d43557642ec6e70dfa85894655 which changed the engine to stable.

Definitely a case of unsupported savegame versions, sorry. But thanks for reporting anyway, one never knows :-)

[raziel-]

Thank you