Opened 6 years ago

Closed 6 years ago

#10561 closed defect (duplicate)

SCUMM: Indiana Jones 3 (FM-Towns) disorted playback in Venice

Reported by: raziel- Owned by: bonki
Priority: normal Component: Engine: SCUMM
Version: Keywords:
Cc: Game: Indiana Jones 3

Description

ScummVM 2.1.0git (May 29 2018 08:17:19)
Features compiled in: Vorbis FLAC MP3 RGB zLib MPEG2 Theora AAC FreeType2 JPEG PNG cloud (servers, local)

I converted the audio tracks of my FM-Towns copy to flac and they play back perfectly with any music player, but in ScummVM especially the Venice loop sounds badly dissorted and off.
The piano piece (is it a piano?) is too low and sounds like it is played on a childs xylophone.

I'm not exactly sure where that piece is located in the audio tracks, i guess it's in track 1 (as the debug log only shows track 1 being opened), but i'm not sure.

I know that FM-Towns versions are super rare and as such bugs for them might never get fixed, but it seems to be a problem of the flac replayer in ScummVM.
I don't have any other version to test, sorry

Indiana Jones and the Last Crusade (FM-TOWNS/English)

AmigaOS4 - SDL - PPC - BE
gcc (adtools build 5.4.0) 5.4.0

Attachments (1)

Indy3_Venice.m4a (448.9 KB ) - added by raziel- 6 years ago.
That doesn't sound right…

Download all attachments as: .zip

Change History (10)

by raziel-, 6 years ago

Attachment: Indy3_Venice.m4a added

That doesn't sound right...

comment:1 by Kirben, 6 years ago

The Venice music is one of the few FM based music tracks in the game, and unfortunately the music in the original version sounds just as bad.

comment:2 by raziel-, 6 years ago

So, the venice Loop is part of the Data (Atlantis.00x) and not of the Audio Tracks?

Top Bad...this Information should be Part of the Readme or at least the Wiki.

Thank you for the hint

comment:3 by raziel-, 6 years ago

Owner: set to raziel-
Resolution: invalid
Status: newclosed

comment:4 by bonki, 6 years ago

See also #1873 for more information.

comment:5 by raziel-, 6 years ago

I missed a 13 year old bug report? :-(

Sorry for the noise...

comment:6 by bonki, 6 years ago

Resolution: invalid
Status: closednew
Summary: SCUMM: Indiana Jones 3 (FM-Towns) disorted flac playback in VeniceSCUMM: Indiana Jones 3 (FM-Towns) disorted playback in Venice

Well, apparently Kirben disabled it in commit b0694e412085cdee19be79d684791494fcad49a2 because the music isn't even played in the original but it was later re-enabled in commit fb61f649035f8d823f4afa5302487d9a30009403 so we are back to square one.
I don't see how the "workaround" from the latter commit is a workaround, it just seems to have re-enabled the music again? From what I gather the distortion doesn't come from the wrong sound type, it's just how it sounds so I wonder if we should disable it again? Why was it re-enabled in the first place?

@Kirben?

comment:7 by raziel-, 6 years ago

Although i'm not suited for answering, i still do :-)

Maybe it was reenabled to make the scene have music at all?
It would be all silent and that is not what the original (EGA/VGA) version does.
If there is no way to improve the quality when playing with FM-TOWNS data i can live with it. At least it's better to have music at all than none.

i take it that this specific piece of music is not in the audio track data?
Otherwise would it be possible to simply play it from the track data on this scene?
I guess not.

comment:8 by bonki, 6 years ago

According to Kirben it is what the original (FMTOWNS) does (there's not much point in comparing it to another version in this regard) but I do agree that it's probably better to keep it as-is to have music at all. For the time being, anyway.

I've updated the comment regarding our workaround and added another reference to this ticket in commit 7df014ea6d63c8ebb831fda2aa69401c4544eebc.

Thanks!

comment:9 by bonki, 6 years ago

Owner: changed from raziel- to bonki
Resolution: duplicate
Status: newclosed
Note: See TracTickets for help on using tickets.