Opened 6 years ago

Closed 6 years ago

#10527 closed defect (fixed)

SCUMM: "imuse play" console command crashes on some tracks, should fail more gracefully

Reported by: JPLeBreton Owned by: bonki
Priority: low Component: Engine: SCUMM
Version: Keywords: imuse, debugger, has-pull-request
Cc: Game:

Description

Steps to repro:

  1. open monkey2 (tested with english DOS version)
  2. open the console and type "imuse play 73"
  3. observe: ScummVM crashes

This happens with a range of games for some values, another example is atlantis (english DOS talkie version) track 195. I'm guessing there is something that makes these tracks genuinely unsuitable for playback, but ScummVM should give a helpful error instead of crashing.

Change History (4)

comment:1 by JPLeBreton, 6 years ago

Keywords: imuse added

I should mention that this is on ScummVM 2.0.0.

comment:2 by bonki, 6 years ago

Keywords: debugger added
Owner: set to bonki
Priority: normal → low
Summary: "imuse play" console command crashes on some tracks, should fail more gracefully → SCUMM: "imuse play" console command crashes on some tracks, should fail more gracefully

Grabbing this, I gave it a very quick look and I think I know what's going on.

comment:3 by bonki, 6 years ago

Keywords: has-pull-request added

Potential fix in ​PR-1192.

comment:4 by bonki, 6 years ago

Resolution: → fixed
Status: new → closed

Fixed in commit d433aedf37672709b8cf3691de1d02498d3077ef.

Note: See TracTickets for help on using tickets.