WME: Carol Reed Mysteries hint system not working

[albadross]

The more recent Carol Reed Mystery games (since 05 - The Colour Of Murder and to date up to 13 - The Birdwatcher) have introduced a hints system (using a file called hints.csv). These work fine running the Wintermute games stand-alone. Could they be made to work under the ScummVM WME engine as well?

[tobiatesan]

Thanks for reporting, the CR games are my all-time WME favourite.

I am not promising anything, but I'll try to have a look sometime during the next month.

[albadross]

To be honest, I have completed all the CR games using ScummVM Wintermute without needing any help. But when I finished them, I looked at the datafiles for the games and found they had a file called hints.csv. I thought that was odd because I have had never seen any hints whilst playing.

Sure enough, when I started playing a couple of the games directly (without ScummVM), the hints appeared.

I am really pleased that someone is taking an interest in the Wintermute engine again. It seems to me to be a really under-rated resource for ScummVM - I have completed more than 30 Wintermute 2D adventures (of varying lengths) using it.

[lolbot-iichan]

I hope I have fixed this with ​https://github.com/scummvm/scummvm/pull/1685

[Filippos Karapetis <bluegr@…>]

In a7efc8a:

WINTERMUTE: Fix Split() method of ext_string

It's hard to believe, but this fixes bug "#10432" WME Carol Reed
Mysteries hint system not working.

Carol Reed hint system happen to heavily use line.Split(";") results,
which were wrong by 1 byte (delimeter was appended to result while it
shouldn't be).

I started with decompiling Carol Reed source code, reproducing issue
with a stand-alone test project (which worked with WME and showed [null]
with ScummVM). then minimized it to a minimal testcase:

var line = new String("New Goal;Visit Christina at the Art
Museum;1;0;S;;");
var ar = line.Split(";");
if((ar[0] == "New Goal")) { var g = ar[1]; }