TUCKER: Bud animation glitch in front of museum

[bonki]

When picking up the nail in front of the museum the lower half of Bud's sprite is missing at the end of the short the animation.

I have not yet verified if this exists in the original.

Screenshot attached.

[bonki]

Attached savegame.

[bonki]

Verified original.

[bonki]

This seems to be a bug in the sprite grab animation table. Picking up an object from the ground uses sprite animation sequence 8:

$ tr '\200-\377' '\000-\200' < CTABLE02.ENC | grep "stoop pick"
dw 01,01,00,0007,0047,0048,0049,0050,0051,0052,0057,0999 ; stoop pick up face right 08

... which is comprised of sprite numbers #47-52 and #57 (this sprite is part of another file, hence the gap).
However, the height of sprite 57 seems to be wrong:

$ tr '\200-\377' '\000-\200' < CTABLE01.ENC | awk -F';' '$2~/00[45][^0]/'
dw 205,000,025,054,004,000 ;0041
dw 267,000,027,054,004,000 ;0042
dw 019,054,027,054,004,000 ;0043
dw 079,054,026,054,002,000 ;0044
dw 141,054,026,054,002,000 ;0045
dw 204,054,025,054,002,000 ;0046   Stoop pick up object
dw 265,054,029,054,002,000 ;0047   and put in jacket
dw 019,108,036,054,004,000 ;0048
dw 080,108.040,054,004,000 ;0049
dw 204,108,038,054,004,000 ;0051
dw 267,108,024,054,004,000 ;0052
dw 002,162,026,020,001,000 ;0053   Head chew gum cont. Bud_1.lbm
dw 034,162,026,020,001,000 ;0054
dw 066,162,026,020,001,000 ;0055
dw 098,162,026,020,001,000 ;0056
dw 018,000,025,024,002,000 ;0057   Stoop pick up object contd.
               ^^^
dw 187,000,028,054,000,000 ;0058   Facing up picking up
dw 219,000,029,054,000,000 ;0059   from waist height

53-56 are head-only sprites but the rest are full-body sprites so #57 should also be 54 pixels high instead of 24, just like the rest of the sequence.

[bonki]

This also means that this is not location-specific but should happen every time this specific pick-up animation is used which I'd like to verify first before I implement a workaround.

[bonki]

I've checked now and sprite 57 is really only used by action 8 which, so it seems, is only ever triggered by picking up the nail at the museum (see ACTION*.ENC).

[bonki]

Fixed in commit 0ec258f5ffcfe75ad5e83f32c7b1b841280bc654.