Opened 5 years ago

Closed 14 months ago

#10304 closed defect (fixed)

SCI: QFG3: Night palette no longer loads after Storyteller event

Reported by: EricOakford Owned by: wjp
Priority: normal Component: Engine: SCI
Version: Keywords:
Cc: Game: Quest for Glory 3

Description

Scummvm: 1.10.0git5264-g9030b09ecc
Game: Quest for Glory III 1.1
OS: Win10-64

After the storyteller tells his story at nightfall, the Hero automatically returns to the guest hut to sleep for the night. The following night, however, the game never loads the palette for nighttime (though the game otherwise treats it as though it is night), making it appear like it's still daytime. This creates odd quirks such as the moon being present in broad daylight at the Pool of Peace or the Hero's room at the Welcome Inn.

I enclosed a savegame right before the storyteller (note that here, the night palette is working properly) This glitch doesn't happen in the original interpreter.

Attachments (3)

qfg3.080 (57.9 KB ) - added by EricOakford 5 years ago.
Savegame just before the storyteller event
scummvm00000.png (159.8 KB ) - added by EricOakford 5 years ago.
While this appears to be daytime, the moon is in the sky.
scummvm00001.png (136.4 KB ) - added by EricOakford 5 years ago.
Checking the time, it is definitely night!

Download all attachments as: .zip

Change History (6)

by EricOakford, 5 years ago

Attachment: qfg3.080 added

Savegame just before the storyteller event

by EricOakford, 5 years ago

Attachment: scummvm00000.png added

While this appears to be daytime, the moon is in the sky.

by EricOakford, 5 years ago

Attachment: scummvm00001.png added

Checking the time, it is definitely night!

comment:1 by wjp, 5 years ago

While sleeping/waking up, _palVaryPaused gets set to 1 and stays stuck there because the palvary Resume call is ignored since _palVaryResourceId == -1 at the time (due to the palVaryProcess call inside kernelPalVaryReverse).

Possibly related to 3e6fb233ac33d74e7045fc8e172e4ac86f5f682c. Need to investigate further.

comment:3 by sluicebox, 14 months ago

Owner: set to wjp
Resolution: fixed
Status: newclosed

Looks like this was fixed three years ago.

https://github.com/scummvm/scummvm/commit/65861bb914a3174a2922ba8f9c6435db0cc70f35 was committed in April 2018 after a thorough discussion in https://github.com/scummvm/scummvm/pull/1075

I verified the fix with the attached save by going to the storyteller, automatically going to sleep, and then waiting for the next night. The night palette shift occurred correctly.

I'm a little concerned that the readme for AshLancer's excellent QFG3 fan patch says this is still a bug in ScummVM, but from the commit history and context I can't tell if that was written before or after this was merged into master: https://github.com/AshLancer/QFG3-Fan-Patch/blob/master/Readme%201.3A.md

Note: See TracTickets for help on using tickets.