Opened 2 years ago

Closed 2 years ago

#10291 closed defect (fixed)

TITANIC: DE: All Chevron text should be in german

Reported by: dafioram Owned by: dreammaster
Priority: low Component: Engine: Titanic
Keywords: Cc:
Game: Starship Titanic

Description

In scummvm the text for a chevron has the words floor, elevator, and room in English, but in the original they are all in German.

Floor = Stock
Elevator = Aufzug
Room = Kabine

Now that I've got the German version of the original game installed I can really start testing!

Attachments (2)

German.png (329.7 KB ) - added by dafioram 2 years ago.
scummvm00001.png (259.7 KB ) - added by dafioram 2 years ago.
scummvm de

Download all attachments as: .zip

Change History (10)

by dafioram, 2 years ago

Attachment: German.png added

by dafioram, 2 years ago

Attachment: scummvm00001.png added

scummvm de

comment:1 by dreammaster, 2 years ago

Owner: set to dreammaster
Resolution: fixed
Status: newpending

Seems I accidentally overlooked adding those strings to the titanic.dat file originally, because their methods were inline in the room_flags.h header file. I've committed a fix. However, since this changes the titanic.dat file, for now I've pushed the changes, but not a regenerated DAT file, to a branch titanic_dat on my dreammaster github account. Since there are already pending changes needed to fix a malformed replacements list in the German version that was replacing Ja with an empty string, I figure it will be all to the best to keep anything that changes the DAT file in this separate branch until the end of the German testing phase, at which point I can merge them all in, as well as a fresh titanic.dat

comment:2 by dafioram, 2 years ago

Don't we want people always running the bleeding edge? How will we know there aren't new problems with an untested titantic.dat if it is not tested during the testing phase? If people try to use a scummvm version that is using an old titanic.dat won't it just tell them that its out of date and they can get a new one?

comment:3 by dafioram, 2 years ago

snover mentioned that some build parameters can be changed so that the buildbot would build the latest titanic.dat and then it would be included in the scummvm people would grab for testing

comment:4 by dreammaster, 2 years ago

There's something in what you say. I guess I can put a fresh titanic.dat on Google Drive and provide a download link. That way I can keep the code up to date, but avoid committing in multiple redundant new titanic.dat files into the master repository until I'm happy with a "final" version

That's probably better than worrying about Buildbot. Even if we got it to build in titanic.dat, it would be linking in the one from Github, which would now be out of date.

comment:5 by dafioram, 2 years ago

Does that just require changing the titanic.dat link in the news doc for the various translations?

comment:6 by dreammaster, 2 years ago

It may well. It'll probably save having to have a completely separate news posting just to announce a temporary alternate source for the file. Then it could be changed back at the end of the testing period, just in case the link gets clicked by anyone after that.

comment:7 by dreammaster, 2 years ago

Actually, it turned out the other problem I thought was data corruption was correctly how the original data was. Since by now several of us have played all the way through the German version, I think it's simplest just to commit the changed DAT into master, rather than worrying about an alternate source.

comment:8 by dreammaster, 2 years ago

Status: pendingclosed
Note: See TracTickets for help on using tickets.