Opened 2 years ago

Closed 2 years ago

#10285 closed defect (fixed)

TITANIC: Wrong ambient audio played back after restoring save game

Reported by: csnover Owned by: dreammaster
Priority: normal Component: Engine: Titanic
Keywords: Cc:
Game: Starship Titanic

Description

  1. Load attached save

Expected: Beautiful gondola music
Actual: Beautiful gondola music mixed with embarkation lobby music

Build: 8d555acc0dcc2c32fee1250b8ae9c7b7020e24ea

Attachments (1)

titanic-win.015 (104.0 KB ) - added by csnover 2 years ago.

Download all attachments as: .zip

Change History (4)

by csnover, 2 years ago

Attachment: titanic-win.015 added

comment:1 by dreammaster, 2 years ago

Now this is an interesting case. First of all, it seems like I'd previously misunderstood how the auto music players operated a bit. They currently have an "_isRepeated" field, which should probably be renamed to "_isEnabled". The game's "project" is set up with an auto music player for each overall room where ambient music is played. And messages are generated when the player enters or leaves the room to turn on the new room's auto music player, whilst turning off any player in the room just left. So only one auto music player should be enabled at a time, and it should only be the one in the currently actively room.

In the case of your savegame, however, the EmbLobby room auto music player is actually turned on, when it obviously shouldn't be. So when the savegame is loaded, it gets reactivated, and the Embarkation Lobby music starts playing. In the little time I had before going to work, I tried entering and leaving the Embarkation Lobby as normal, and it's auto music player was correctly disabled. I don't suppose you did anything non-standard for the game before saving, such as using the cheat room?

If not, I guess I can at least code in a workaround.. maybe pass the now active room as part of the LoadSuccessMsg call, and have the auto music player automatically flag itself as off if it's not in the active room

comment:2 by csnover, 2 years ago

No cheats/debugs were used in the creation of this save game. All I had to do was save in the gondola room.

comment:3 by dreammaster, 2 years ago

Owner: set to dreammaster
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.