SCI: RAMA: Misplaced zero for bangkok sum/difference puzzles

[dafioram]

ScummVM: 1.10.0git-5097-gd75dab4
Game: RAMA 1.0 DOS/English
Tester OS: Win7-64

When doing anyone of the three sum/difference puzzles (the right most terminal on each level) there will be a symbol in the top left corner that represents the value zero for that alien species. It does not change and it is not on the terminal screen.

It doesn't appear to be in the original since it is not present during this dosbox players play-through. ​https://youtu.be/WEI9Uyssh44?t=362, but maybe he has a patch.

[dafioram]

bangkok top level

[dafioram]

The white rectangle in the top left shouldn't be there.

[csnover]

So what seems to be going on here is that the game stacks unused question digit views in the top-left corner for the arithmetic puzzle. These views are not fully initialised so they are just cel 0 views which happens to correspond to the digit 0 (even though the views themselves aren’t for digit 0). Since this running into the last-ditch sorting algorithm again (vs the plane pic), I guess we’re consistently sorting the digits higher than the plane pic cel. It looks like the game messes with priorities on the digits it actually uses, so hopefully I can just script patch it the unused priority to -1.

[csnover]

Oh, yeah. This totally makes sense. The plane pic screen items get synthetic IDs which are *always* higher than game views will be in SSCI during last-ditch sorting comparisons. So we should be doing that too.

[csnover]

Thanks for your report! A patch for this issue has been added in commit 8985f8f447a04d2a46b509fdf225cd87c00c9ba9 and will be available in daily builds 1.10.0git-5108 and later.