SCI: Lighthouse: Bad sound effect when clipping train rails

[dafioram]

Game: Lighthouse 1.0c/2.0a
Tester OS: Ubuntu 17.07
ScummVM: 1.10.0git-5016-g4890dd4466

I used the same saved game from 2.0a to test lighthouse 1.0c in ScummVM. This is not present in the original game v2.0a, but I don't know about 1.0c.

I played the original game using Jafa's winxp installation. ​​​​​http://www.squirtthecat.com/games/lighthouse/index.html. Which is one of the two options endorsed by ​​​​​http://www.sierrahelp.com/Games/LighthouseHelp.html

When repairing the track you must clip the rails at two spot using the metal clipper both times when you do this it will play a bad version of the audio effect. It sounds like something is getting jammed/stuck.

I believe this sound bug sounds the same as in #10231 and #10224.

[dafioram]

track is out

[dafioram]

The data files that I thought were for 1.0c are, I believe actually 2.0, so you can ignore this bug being for 1.0c since I cannot test that.

[dafioram]

Here is my play through of this on the original engine. ​https://streamable.com/s6oip

[bluegr]

This happens in room 270. It's a script bug, as the game tries to play the same sound sample 12 times. Perhaps we're missing a flag in ScummVM.

[dafioram]

I believe it does happen in the original engine when played on dosbox.

I think Jafas winxp changes fix these issues and that is why I didn't experience it.

[sluicebox]

Fixed in ​https://github.com/scummvm/scummvm/commit/6d2c4222b313818350f79fda7864cf2bf28d4f26