Opened 7 years ago

Closed 5 years ago

Last modified 5 years ago

#10221 closed defect (fixed)

SCI: KQ7 v1.4 Bad view priority, Ego behind curtain, Chapter 5

Reported by: dafioram Owned by: sluicebox
Priority: low Component: Engine: SCI
Version: Keywords: sci32 original
Cc: Game: King's Quest 7

Description

Game: KQ7 v1.4
OS: win7-64
scummvm: 1.10.0git-4882-g1504f41

Doesn't happen in v2.00b. At the beginning of chapter 5 after giving the statue to the snake you can walk behind his curtain.

Attachments (4)

scummvm00000.png​ (261.3 KB ) - added by dafioram 7 years ago.
KQ7_1.4.png​ (159.3 KB ) - added by dafioram 7 years ago.
save.zip​ (42.1 KB ) - added by dafioram 7 years ago.
dafioram-diff.txt​ (232.3 KB ) - added by m-kiewitz 7 years ago.
Dafioram's diff

Download all attachments as: .zip

Change History (14)

by dafioram, 7 years ago

Attachment: scummvm00000.png​ added

comment:1 by m-kiewitz, 7 years ago

Does this also happen, when using the original interpreter?

by dafioram, 7 years ago

Attachment: KQ7_1.4.png​ added

by dafioram, 7 years ago

Attachment: save.zip​ added

comment:2 by dafioram, 7 years ago

Yes.

comment:3 by csnover, 7 years ago

Summary: SCI: KQ7 Bad palette priority, Ego behind curtain, Chapter 5 → SCI: KQ7 Bad view priority, Ego behind curtain, Chapter 5

comment:4 by csnover, 7 years ago

Keywords: sci32 added

comment:5 by dafioram, 7 years ago

If I compare 1.4 vs 2.0b I see that in script/room 5300 the priority for the curtain object is 98 (1.4) vs 90 (2.0b) this probably doesn't matter though since the KQEgo priority (owned by script 13) has a priority of 109 at this point.

The only other difference I see for the properties of the curtain is that -methDict- is 466 (1.4) vs. 294 (2.0b).

curtain setPri are the same.

comment:6 by dafioram, 7 years ago

Here is the two files the first revision is the 5300 file for 1.4 and the 2nd is for 2.0b. I did a full decompile of all files so function names and such should be resolved.

​https://gist.github.com/dafioram/5ce7c5d14d88dd98128b04da07c79073

I was hoping that the gist would give me a diff side by side, but i guess the files are too long.

comment:7 by dafioram, 7 years ago

Here is a better diff, shows 1.4->2.0b for script 5300.
​https://pastebin.com/SWCKxgKa

by m-kiewitz, 7 years ago

Attachment: dafioram-diff.txt​ added

Dafioram's diff

comment:8 by dafioram, 7 years ago

Summary: SCI: KQ7 Bad view priority, Ego behind curtain, Chapter 5 → SCI: KQ7 v1.4 Bad view priority, Ego behind curtain, Chapter 5

comment:9 by sluicebox, 5 years ago

Keywords: original added
Owner: set to sluicebox
Resolution: → fixed
Status: new → closed

Fixed in 1748825c36724b139aa772dd1ddc366d4408e884

comment:10 by dafioram, 5 years ago

Nice work.

Note: See TracTickets for help on using tickets.