TITANIC: DoorBot and BellBot stay put if you walk out of a room

[csnover]

Build: 9512cf46b739b2ca37c0e101fa440ece5072b722 + PR 1000, macOS 10.11, SDL 2.0.5, ASan on

If you summon DoorBot or BellBot at a door to a room, and then walk forward through the door, the game will not wait for the bot to say goodbye and leave, so the next time you go back to the same location the bot will still be standing there.

1. Load attached save
2. Walk forward out the door
3. Turn around
4. Walk back into the room
5. Turn around again

Expected: Game stops at step 2 to let the bot finish saying goodbye and exit, or at least resets the bot’s flags so he is not still in the room once you leave
Actual: Game lets you walk out the door immediately, cutting off the bot goodbye speech/animation and leaving the bot in the room

I do not know if this is also a bug in the original engine.

[dafioram]

This is present in the original game.

Although the game trys to block calling the doorbot/bellbot when in front of several of the doors (like the embarkation lobby), by saying "it is not possible to summon from this location", it does not block all of them.

In the original game if you go into the parrot room and then turn and face the door, then call a bot, you can reproduce this behavior (the bot will be there when you go back into the parrot room and turn to face the door).

One possible solution would be to block bots from being callable at all node/views facing a door.

[dreammaster]

I've done an alternative solution where both for the Bellbot and Doorbot, it checks for when you enter a view it's in (and it's in the summonable areas, to avoid causing any trouble in the prologue lift), it'll automatically remove it. This is safer then removing it when you leave the view, since we don't have to worry about not removing it until after any leaving animation the bots do had completed.