TITANIC: Music room xylopho player doesn't animate

[dafioram]

When you play music in the music room and he is enabled you can hear his parts played, but he doesn't move at all. He did in previous versions of summvm and he does in the original.

If you turn off all the others (dim all the green lights except top left) and then hit the red button he will start playing after about 30 seconds.

e84c164bde6ebf45ff4e84089e4d0c25bb03d8b6

[dreammaster]

Hmmm.. I'm trying to remember if I ever saw it animating properly at all. I've tried various earlier versions, and none of them were animating. If you can remember if you could remember when, if ever, you saw it animating?

Looking at the video file itself for the bells, the file, y222.avi, has a weird header with only a single video frame listed. This may represent some non-standard type of AVI file, though the Media Player does play it, so there may be hope of me figuring it out by looking at other video tools source, like ffmpeg.

[dafioram]

You're right I don't see that scummvm ever did this, I guess I was remembering him moving from the original engine. He should start moving about 60 secs into the song btw. You might need the correct solution for him to move.

[dreammaster]

Okay, playback of the video is fixed. Turns out it was just a bad "total number of frames" value in the header. I implemented a clean stub class to allow fixing the header on the fly as it's read in from the file. Still need to review some custom timing code the game sets the video to, so I'm leaving the bug open for now.