TITANIC: crash in music room after starting music

[dafioram]

1.10.0git-4350-g8b81bb2

In the music room go up to the panel and hit the red button then wait 3 seconds for them to start playing and hit the red button again.

common/array.h
Expression: idx < _size

backtrace:

#0  0x00007ffff4aa0428 in __GI_raise (sig=sig@entry=6)
    at ../sysdeps/unix/sysv/linux/raise.c:54
#1  0x00007ffff4aa202a in __GI_abort () at abort.c:89
#2  0x00007ffff4a98bd7 in __assert_fail_base (fmt=<optimized out>, 
    assertion=assertion@entry=0x807580 "idx < _size", 
    file=file@entry=0x80756f "./common/array.h", line=line@entry=164, 
    function=function@entry=0x807800 <Common::Array<Titanic::QMixer::ChannelEntry>::operator[](unsigned int)::__PRETTY_FUNCTION__> "T& Common::Array<T>::operator[](Common::Array<T>::size_type) [with T = Titanic::QMixer::ChannelEntry; Common::Array<T>::size_type = unsigned int]") at assert.c:92
#3  0x00007ffff4a98c82 in __GI___assert_fail (
    assertion=0x807580 "idx < _size", file=0x80756f "./common/array.h", 
    line=164, 
    function=0x807800 <Common::Array<Titanic::QMixer::ChannelEntry>::operator[](unsigned int)::__PRETTY_FUNCTION__> "T& Common::Array<T>::operator[](Common::Array<T>::size_type) [with T = Titanic::QMixer::ChannelEntry; Common::Array<T>::size_type = unsigned int]") at assert.c:101
#4  0x0000000000562cd6 in Common::Array<Titanic::QMixer::ChannelEntry>::operator[] (this=0x17a7290, idx=4294967295) at ./common/array.h:164
#5  0x0000000000562120 in Titanic::QMixer::qsWaveMixFlushChannel (
    this=0x17a7288, iChannel=-1, flags=0)
    at engines/titanic/sound/qmixer.cpp:71
#6  0x000000000050bc72 in Titanic::QSoundManager::stopSound (this=0x17a7258, 
    handle=0) at engines/titanic/sound/sound_manager.cpp:199
#7  0x0000000000504744 in Titanic::CMusicRoomHandler::stop (this=0x12d4300)
    at engines/titanic/sound/music_room_handler.cpp:104
#8  0x00000000005040db in Titanic::CMusicRoom::stopMusic (this=0x17a71f8)
    at engines/titanic/sound/music_room.cpp:95
#9  0x00000000005034a6 in Titanic::CMusicPlayer::StopMusicMsg (this=0x1b9a2c0, 
    msg=0x7ffffffb7cc0) at engines/titanic/sound/music_player.cpp:92
#10 0x00000000004c7144 in Titanic::CMessage::perform (this=0x7ffffffb7cc0, 
    treeItem=0x1b9a2c0) at engines/titanic/messages/messages.cpp:105
#11 0x00000000004c6ee9 in Titanic::CMessage::execute (this=0x7ffffffb7cc0, 
    target=0x1b9a2c0, classDef=0x0, flags=3)
    at engines/titanic/messages/messages.cpp:58
#12 0x000000000049980f in Titanic::CMusicConsoleButton::MouseButtonDownMsg (
    this=0x1b9a2c0, msg=0x7ffffffb7fe0)
    at engines/titanic/game/music_console_button.cpp:49
#13 0x00000000004c7144 in Titanic::CMessage::perform (this=0x7ffffffb7fe0, 
    treeItem=0x1b9a2c0) at engines/titanic/messages/messages.cpp:105
#14 0x00000000004c6ee9 in Titanic::CMessage::execute (this=0x7ffffffb7fe0, 
    target=0x1b9a2c0, classDef=0x0, flags=3)
    at engines/titanic/messages/messages.cpp:58
#15 0x000000000047beef in Titanic::CViewItem::handleMouseMsg (this=0x1b99440, 
    msg=0x7ffffffb7fe0, flag=true) at engines/titanic/core/view_item.cpp:294
#16 0x000000000047b8f0 in Titanic::CViewItem::MouseButtonDownMsg (
    this=0x1b99440, msg=0x7ffffffb7fe0)
    at engines/titanic/core/view_item.cpp:189
#17 0x00000000004c7144 in Titanic::CMessage::perform (this=0x7ffffffb7fe0, 
    treeItem=0x1b99440) at engines/titanic/messages/messages.cpp:105
#18 0x00000000004c6ee9 in Titanic::CMessage::execute (this=0x7ffffffb7fe0, 
    target=0x1b99440, classDef=0x0, flags=3)
    at engines/titanic/messages/messages.cpp:58
#19 0x000000000054e8db in Titanic::CInputHandler::dispatchMessage (
    this=0x17a71b8, msg=0x7ffffffb7fe0)
    at engines/titanic/input_handler.cpp:153
#20 0x000000000054e4ed in Titanic::CInputHandler::processMessage (
    this=0x17a71b8, msg=0x7ffffffb7fe0) at engines/titanic/input_handler.cpp:81
#21 0x000000000054e44a in Titanic::CInputHandler::handleMessage (
    this=0x17a71b8, msg=..., respectLock=true)
    at engines/titanic/input_handler.cpp:69
#22 0x000000000054eca5 in Titanic::CInputTranslator::leftButtonDown (
    this=0x17a71e8, special=1, pt=...)
    at engines/titanic/input_translator.cpp:55
#23 0x00000000005501e0 in Titanic::CMainGameWindow::leftButtonDown (
    this=0x1539db0, mousePos=...) at engines/titanic/main_game_window.cpp:278
#24 0x000000000054a0f6 in Titanic::Events::pollEvents (this=0x1537bd0)
    at engines/titanic/events.cpp:57
#25 0x000000000054a370 in Titanic::Events::pollEventsAndWait (this=0x1537bd0)
    at engines/titanic/events.cpp:108
#26 0x0000000000423105 in Titanic::TitanicEngine::run (this=0xd2cca0)
    at engines/titanic/titanic.cpp:144
#27 0x000000000040dfce in runGame (plugin=0xc46fe0, system=..., 
    edebuglevels=...) at base/main.cpp:263
#28 0x000000000040f191 in scummvm_main (argc=1, argv=0x7fffffffdf38)
    at base/main.cpp:529
#29 0x000000000040c13e in main (argc=1, argv=0x7fffffffdf38)
    at backends/platform/sdl/posix/posix-main.cpp:45

[dafioram]

music room

[dafioram]

If you have hit the play button then the game will crash whether you hit the red button or turn left/right. Doesn't matter if the music is playing or if it has finished. Therefore this puzzle can no longer be finished.

Solving this may also solve #10109.

[dafioram]

music room before solving puzzle

[dafioram]

This bug was introduced by 1f4b97ac7c2350dac7f4edf6976d62879a763546 (August 3rd).

[dafioram]

Fixed by 2df37f4eb0dc661c0159ca397e66ef6fe19de64c