TITANIC: Can't load barbot room saves from original game for a few node/view combinations

[dafioram]

scummvm: f4f15667a5a7cdde12f5aa7ccf1b7384277bffc4

If I try to load a valid saved game from the original titanic crashes on start. Other saved games from the original work and this saved game works when I play it on the original engine.

The save is at the bar.

[dafioram]

#0  0x0000000000000000 in ?? ()
#1  0x000000000044f257 in Titanic::CSaveableObject::createInstance (name=...)
    at engines/titanic/core/saveable_object.cpp:1639
#2  0x000000000042d2ce in Titanic::List<Titanic::CMovieRangeInfo>::load (
    this=0x1e2e698, file=0x7ffffffb7eb0) at ./engines/titanic/core/list.h:114
#3  0x00000000004259a1 in Titanic::CGameObject::load (this=0x1e2e600, 
    file=0x7ffffffb7eb0) at engines/titanic/core/game_object.cpp:142
#4  0x00000000004d3909 in Titanic::CCharacter::load (this=0x1e2e600, 
    file=0x7ffffffb7eb0) at engines/titanic/npcs/character.cpp:53
#5  0x00000000004e2577 in Titanic::CTrueTalkNPC::load (this=0x1e2e600, 
    file=0x7ffffffb7eb0) at engines/titanic/npcs/true_talk_npc.cpp:79
#6  0x00000000004cccea in Titanic::CBarbot::load (this=0x1e2e600, 
    file=0x7ffffffb7eb0) at engines/titanic/npcs/barbot.cpp:146
#7  0x0000000000431173 in Titanic::CProjectItem::loadData (this=0x199f840, 
    file=0x7ffffffb7eb0) at engines/titanic/core/project_item.cpp:277
#8  0x0000000000430c7b in Titanic::CProjectItem::loadGame (this=0x199f840, 
    slotId=14) at engines/titanic/core/project_item.cpp:183
#9  0x000000000054e9ed in Titanic::CMainGameWindow::applicationStarting (
    this=0x14898b0) at engines/titanic/main_game_window.cpp:79
#10 0x0000000000422f3e in Titanic::TitanicEngine::initialize (this=0x143c6e0)
    at engines/titanic/titanic.cpp:114
#11 0x00000000004230cc in Titanic::TitanicEngine::run (this=0x143c6e0)
    at engines/titanic/titanic.cpp:141
#12 0x000000000040e00e in runGame (plugin=0xc05960, system=..., 
    edebuglevels=...) at base/main.cpp:263
#13 0x000000000040f1d1 in scummvm_main (argc=1, argv=0x7fffffffdf38)
    at base/main.cpp:529
#14 0x000000000040c17e in main (argc=1, argv=0x7fffffffdf38)
    at backends/platform/sdl/posix/posix-main.cpp:45

[dafioram]

I've identified that the game crashes when loading a saved game from the original at the barbot area if you've are at the node just outside of the pellerator and you are facing: North, North East, or North West. Were North means you are facing the barbot. There is no option to face east or west.

If you make saves with scummvm they work in all those positions.

[dafioram]

Original saved game, barbot, facing north, crashes

[dafioram]

Original saved game, barbot, facing north-west, crashes

[dafioram]

Original saved game, barbot, facing north-east, crashes

[dafioram]

Original saved game, barbot, facing south (pellarator), does not crash

[dafioram]

Original saved game, barbot, facing north, one-step north of pellerator, does not crashes

[dafioram]

I tested all of the other nodes and views in the bar and there are a few other spots where the game crashes for loading those original game saved.

There are 5 nodes in this room:

1. In front of Pellerator
2. In front of bar
3. In front of TV (left of bar)
4. Right of bar
5. Right of bar and north (in front of succ)

Only nodes 1,2, and 3 have views that crash. I've already attached all the node 1 (pellerator) related saves that crash.

In total for this room their are 6 node/view combinations that crash.

Now I will only attached the other node/views that crash.

I loaded lots of saved games from the original game, all from various points in the game, and all the rest worked so I will assume the rest of the game is good.

[dafioram]

In front of bar, facing west, crash

[dafioram]

Left of bar, facing east, crashes

[dafioram]

Left of bar, facing North-East, crashes