Opened 2 years ago

Closed 2 years ago

#10037 closed defect (fixed)

SCI: PHANT2: Some inventory items overlap the arrow buttons

Reported by: dafioram Owned by: csnover
Priority: low Component: Engine: SCI
Keywords: sci32 Cc:
Game: Phantasmagoria 2

Description

Game: Phant 2 GOG CD/DOS 001.0.06
ScummVM: 1.10.0git-4161-gcb3191a
OS: Ubuntu 16.04

Some of the larger items like the Buisness card overlap the left/right inventory scroll buttons. Maybe the buttons could be move out a little?

Not sure if in the original or not.

Attachments (3)

scummvm00008.png (238.5 KB ) - added by dafioram 2 years ago.
Right button overlapping hammer
scummvm00007.png (238.3 KB ) - added by dafioram 2 years ago.
Business card overlapping left button
phantasmagoria2-cd-win.019 (42.5 KB ) - added by dafioram 2 years ago.
save with lots of inventory items

Download all attachments as: .zip

Change History (7)

by dafioram, 2 years ago

Attachment: scummvm00008.png added

Right button overlapping hammer

by dafioram, 2 years ago

Attachment: scummvm00007.png added

Business card overlapping left button

by dafioram, 2 years ago

Attachment: phantasmagoria2-cd-win.019 added

save with lots of inventory items

comment:1 by dafioram, 2 years ago

Summary: PHANT2: Some inventory items overlap the arrow buttonsSCI: PHANT2: Some inventory items overlap the arrow buttons

comment:2 by csnover, 2 years ago

Type: enhancementdefect

This game is a mess.

First, inventory items are 58 pixels wide plus 7 pixels of padding, but the game incorrectly advances by 66 pixels instead of 65 pixels every time you click one of the inventory buttons, so they start creeping left and eventually start drawing over the left arrow.

Second, the placement of the inventory items is 9 pixels too far to the right relative to the left edge of the inventory viewport, which is why they get cut off on the right.

Third, the left arrow button is drawn 6 pixels over the left edge of the inventory viewport, which is why they can start to draw over the arrow on the left.

Also, they just didn’t care enough to fix the bad hover state of the left inventory arrow before releasing the game either.

comment:3 by csnover, 2 years ago

Owner: set to csnover

comment:4 by csnover, 2 years ago

Resolution: fixed
Status: newclosed

Thanks for your report! A patch for this issue has been added in commit b8af2ca66f3f565ad0d86761d9eac3b69d68c52d and will be available in daily builds 1.10.0git-4880 and higher.

Note: See TracTickets for help on using tickets.